Skip to content

Commit fee256b

Browse files
committed
Tighten up test assertions after review
Signed-off-by: Tim Perry <pimterry@gmail.com>
1 parent bf0129b commit fee256b

1 file changed

Lines changed: 13 additions & 1 deletion

File tree

test/parallel/test-http-client-request-listeners-leak.js

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
'use strict';
22
const common = require('../common');
3+
const assert = require('assert');
34
const http = require('http');
45
const { defaultMaxListeners } = require('events');
56

@@ -16,6 +17,14 @@ server.listen(0, common.mustCall(() => {
1617
const agent = new http.Agent({ keepAlive: true });
1718
const port = server.address().port;
1819

20+
// Count actual socket creations to confirm reuse:
21+
let createSocketCount = 0;
22+
const origCreateSocket = agent.createSocket.bind(agent);
23+
agent.createSocket = function(...args) {
24+
createSocketCount++;
25+
return origCreateSocket(...args);
26+
};
27+
1928
function executeHttpGet() {
2029
return new Promise((resolve) => {
2130
const req = http.get({ host: '127.0.0.1', port, agent });
@@ -30,9 +39,12 @@ server.listen(0, common.mustCall(() => {
3039
for (let i = 0; i < defaultMaxListeners + 1; i++) {
3140
await executeHttpGet();
3241
}
42+
43+
assert.strictEqual(createSocketCount, 1);
44+
3345
server.close();
3446
agent.destroy();
3547
}
3648

37-
main();
49+
main().then(common.mustCall());
3850
}));

0 commit comments

Comments
 (0)