fix: detect Confluence Cloud instances in Multi-Cloud OAuth mode (sooperset#586)

* fix: detect Confluence Cloud instances in Multi-Cloud OAuth mode

When using Multi-Cloud OAuth with BYOT (Bring Your Own Token) flow,
Confluence's is_cloud property incorrectly returned false because it
only checked the URL pattern. In Multi-Cloud setups, the URL may be
None or empty as requests use api.atlassian.com with a cloud_id.

This fix ensures that OAuth configurations with a cloud_id are always
treated as Cloud instances, enabling proper v2 API adapter activation
and preventing authentication failures.

The implementation matches the fix already applied to Jira in PR sooperset#581.

Reported-by: Ian
Github-Issue: sooperset#580

* chore: revert uv.lock changes from previous commit

Reverts unintended uv.lock changes that were included in the fix for
Confluence Cloud detection in Multi-Cloud OAuth mode.

Author: sooperset

src/mcp_atlassian/confluence/config.py

@@ -45,7 +45,17 @@ def is_cloud(self) -> bool:
             True if this is a cloud instance (atlassian.net), False otherwise.
             Localhost URLs are always considered non-cloud (Server/Data Center).
         """
-        return is_atlassian_cloud_url(self.url)
+        # Multi-Cloud OAuth mode: URL might be None, but we use api.atlassian.com
+        if (
+            self.auth_type == "oauth"
+            and self.oauth_config
+            and self.oauth_config.cloud_id
+        ):
+            # OAuth with cloud_id uses api.atlassian.com which is always Cloud
+            return True
+
+        # For other auth types, check the URL
+        return is_atlassian_cloud_url(self.url) if self.url else False
 
     @property
     def verify_ssl(self) -> bool:

tests/unit/confluence/test_config.py

@@ -159,3 +159,27 @@ def test_from_env_proxy_settings():
             config.socks_proxy == "socks5://user:[email protected]:1080"
         )
         assert config.no_proxy == "localhost,127.0.0.1,.internal.example.com"
+
+
+def test_is_cloud_oauth_with_cloud_id():
+    """Test that is_cloud returns True for OAuth with cloud_id regardless of URL."""
+    from mcp_atlassian.utils.oauth import BYOAccessTokenOAuthConfig
+
+    # OAuth with cloud_id and no URL - should be Cloud
+    oauth_config = BYOAccessTokenOAuthConfig(
+        cloud_id="test-cloud-id", access_token="test-token"
+    )
+    config = ConfluenceConfig(
+        url=None,  # URL can be None in Multi-Cloud OAuth mode
+        auth_type="oauth",
+        oauth_config=oauth_config,
+    )
+    assert config.is_cloud is True
+
+    # OAuth with cloud_id and server URL - should still be Cloud
+    config = ConfluenceConfig(
+        url="https://confluence.example.com",  # Server-like URL
+        auth_type="oauth",
+        oauth_config=oauth_config,
+    )
+    assert config.is_cloud is True