fix to only consider bracketization if tokens aren't already bracketized

Author: nycdotnet

Code/TSqlFlex.Core.Tests/DataScriptingTests.cs

@@ -842,6 +842,12 @@ public void SimpleObjectName_IsNotEscaped()
             Assert.AreEqual("dbo.mytable", FieldScripting.EscapeObjectNames("dbo.mytable"));
         }
 
+        [Test()]
+        public void AlreadyEscapedObjectName_IsNotEscaped()
+        {
+            Assert.AreEqual("[dbo].[mytable]", FieldScripting.EscapeObjectNames("[dbo].[mytable]"));
+        }
+
         [Test()]
         public void ObjectNameWithSpace_IsEscaped()
         {

Code/TSqlFlex.Core/FieldScripting.cs

@@ -134,11 +134,18 @@ public static string EscapeObjectNames(string dotSeparatedRawObjectNames)
             var items = dotSeparatedRawObjectNames.Split('.');
             for (int i = 0; i < items.Length; i += 1 )
             {
-                items[i] = EscapeObjectName(items[i]);
+                if (!IsBracketEscaped(items[i])) { 
+                    items[i] = EscapeObjectName(items[i]);
+                }
             }
             return string.Join(".", items);
         }
 
+        private static bool IsBracketEscaped(string objectName)
+        {
+            return (objectName.StartsWith("[") && objectName.EndsWith("]"));  //bug: this is good enough for now, but may not properly consider edge case escaped ] as the final character for example
+        }
+
         public static StringBuilder scriptDataAsInsertForSQL2008Plus(string tableName, FlexResult result, int MaxRowsInValuesClause)
         {
             const int INITIAL_CAPACITY = 50000; //This is small enough that it won't matter, but big enough to ensure minimal initial resizes.