Treat timestamp partition value as UTC

rui-mo · JkSelf · commit 400a0d87ed33 · 2024-02-04T17:14:27.000+08:00
diff --git a/velox/connectors/hive/SplitReader.cpp b/velox/connectors/hive/SplitReader.cpp
@@ -287,9 +287,9 @@ velox::variant convertFromString(
           StringView(value.value()), true /*isIso8601*/));
     }
     auto result = velox::util::Converter<ToKind>::cast(value.value());
-    if constexpr (ToKind == TypeKind::TIMESTAMP) {
-      result.toGMT(Timestamp::defaultTimezone());
-    }
+    // if constexpr (ToKind == TypeKind::TIMESTAMP) {
+    //   result.toGMT(Timestamp::defaultTimezone());
+    // }
     return velox::variant(result);
   }
   return velox::variant(ToKind);

Original file line number	Diff line number	Diff line change
`@@ -287,9 +287,9 @@ velox::variant convertFromString(`
`287`	`287`	`StringView(value.value()), true /isIso8601/));`
`288`	`288`	`}`
`289`	`289`	`auto result = velox::util::Converter<ToKind>::cast(value.value());`
`290`		`- if constexpr (ToKind == TypeKind::TIMESTAMP) {`
`291`		`- result.toGMT(Timestamp::defaultTimezone());`
`292`		`- }`
	`290`	`+ // if constexpr (ToKind == TypeKind::TIMESTAMP) {`
	`291`	`+ // result.toGMT(Timestamp::defaultTimezone());`
	`292`	`+ // }`
`293`	`293`	`return velox::variant(result);`
`294`	`294`	`}`
`295`	`295`	`return velox::variant(ToKind);`