disable warnings on windows and macos #12750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
rgrinberg
reviewed
Nov 19, 2025
Alizter
force-pushed
the
push-lnyzuvoxptpt
branch
2 times, most recently
from
79fb17f to
d90f49a
Compare
Alizter
changed the title
Alizter
force-pushed
the
push-lnyzuvoxptpt
branch
4 times, most recently
from
25e647f to
694042e
Compare
Alizter
changed the title
rgrinberg
reviewed
Nov 20, 2025
| (foreign_stubs | ||
| (language c) | ||
| (names blake3_stubs) | ||
| (flags :standard -O3))) |
Member
There was a problem hiding this comment.
Is this relevant to this PR? If not, I suggest move it to a separate PR
Collaborator
Author
There was a problem hiding this comment.
Yes, it is relevant. First we don't even set -O3 in the bootstrap so the development build is simply different. Secondly MSVC doesn't understand -O3 and emits a warning when it encounters it. -O2 as found in :standard however is fine.
Alizter
commented
Nov 20, 2025
Comment on lines
+23
to
+24
| (flags | ||
| (-w -3-6-27-32-33-35-50))) |
Collaborator
Author
There was a problem hiding this comment.
These don't actually do anything but I won't touch them here.
rgrinberg
approved these changes
Nov 25, 2025
Alizter
force-pushed
the
push-lnyzuvoxptpt
branch
from
694042e to
bf4a6b2
Compare
Signed-off-by: Ali Caglayan <[email protected]>
This disables the warnings during the compilation of ocaml-notify on Windows mingw and macos. Signed-off-by: Ali Caglayan <[email protected]>
We don't use -O3 in the bootstrap so there is little point passing it here. O3 also doesn't make sense for MSVC which would warn about this. Signed-off-by: Ali Caglayan <[email protected]>
Alizter
force-pushed
the
push-lnyzuvoxptpt
branch
from
bf4a6b2 to
87ea22b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the specific warnings we get when compiling lmdb and it's OCaml stubs on Windows (msvc and mingw only). We don't intend to fix them so they are just noise for our CI.