fix(oxcaml): js_of_ocaml compile whole for parameterised instances #12762
+135
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
art-w
force-pushed
the
instantiate-parameterized-jsoo
branch
from
d15c57b to
bfd327b
Compare
art-w
force-pushed
the
instantiate-parameterized-jsoo
branch
4 times, most recently
from
3b9d28e to
c28e071
Compare
art-w
force-pushed
the
instantiate-parameterized-jsoo
branch
2 times, most recently
from
81a60a9 to
3093ce9
Compare
Signed-off-by: Arthur Wendling <[email protected]>
art-w
force-pushed
the
instantiate-parameterized-jsoo
branch
from
3093ce9 to
129c90d
Compare
Alizter
reviewed
Dec 5, 2025
| | Not_parameterised -> false | ||
| | Complete | Partial -> true) | ||
| in | ||
| (* jsoo supports only whole program compilation of parameterised instances, |
Collaborator
There was a problem hiding this comment.
Is this limitation permanent or will it be relaxed in a later jsoo version?
Collaborator
There was a problem hiding this comment.
It would be good to know if support is needed inside the jsoo compiler or if one just need to fix the dune rule ..
Collaborator
Author
There was a problem hiding this comment.
I've added some explanations in #12564 (comment) regarding the bytecode error I'm seeing when doing separate compilation in jsoo, so I think it requires an oxcaml-specific patch in jsoo before we can change the dune rules for separate compilation :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12564
Follow up on #12561 :
Js_of_ocaml and wasm_of_ocaml don't currently support the incremental compilation of OxCaml parameterised libraries instantiation, so we have to enforce whole program compilation.