[IMP] excise_management: Replace automation logic with server action

Replaced automation-based report line generation with a compute trigger
using a dedicated boolean field.

Key updates:
- Added computed boolean field `x_details_computation` on `x_excise_report`
  to trigger `ir_action_compute_excise_report_line`
- Implemented server action to:
  • fetch relevant stock moves
  • group data by excise category and move type
  • create report lines and bind stock moves
  • update `x_line_ids` and mark computation status

Author: amas-odoo

beverage_distributor/data/knowledge_article.xml

@@ -131,9 +131,9 @@ Create a warehouse for each branch: Go to Inventory > Configuration > Ware
 <p><strong>Excise reporting</strong></p>
 <p>On top of the legal reporting, you need as well to know at all time the quantity of excise submitted products in your fiscal deposit warehouses.</p>
 <ul>
-    <li><p>Open the <strong>Inventory app</strong> and reach the Excise Reports from the Reporting menu.</p></li>
-    <li><p>Rows come with the same move types detailed as the Excise Reports.</p></li>
-    <li><p>The Total row allows you to capture your currently in fiscal deposit warehouse product quantity!</p></li>
+    <li>Open the <strong>Inventory app</strong> and reach the Excise Reports from the Reporting menu.</li>
+    <li>Rows come with the same move types detailed as the Excise Reports.</li>
+    <li>The Total row allows you to capture your currently in fiscal deposit warehouse product quantity!</li>
 </ul>
 <p>You now have the keys to easily report those to the relevant authorities!</p>
             <p><a href="https://apps.odoo.com/apps/modules/19.0/excise_management" class="btn btn-outline-primary btn-sm" target="_blank">🎓 Excise Management</a></p>

excise_management/data/base_automation.xml

@@ -27,17 +27,4 @@
         <field name="trigger">on_create_or_write</field>
         <field name="trigger_field_ids" eval="[(6, 0, [ref('account.field_account_tax__tax_group_id')])]"/>
     </record>
-    <record id="base_automation_create_excise_report_line" model="base.automation">
-        <field name="model_id" ref="excise_report"/>
-        <field name="action_server_ids" eval="[(6, 0, [ref('ir_action_create_excise_report_line')])]"/>
-        <field name="trigger">on_create</field>
-        <field name="name">Create Excise Report Line</field>
-    </record>
-    <record id="base_automation_update_excise_report_line_onupdate_stock_move" model="base.automation">
-        <field name="model_id" ref="stock.model_stock_move"/>
-        <field name="action_server_ids" eval="[(6, 0, [ref('ir_action_update_excise_report_line_onupdate_stock_move')])]"/>
-        <field name="trigger">on_create_or_write</field>
-        <field name="name">Update Excise line: when changing state and date</field>
-        <field name="trigger_field_ids" eval="[(6, 0, [ref('stock.field_stock_move__date'), ref('stock.field_stock_move__state')])]"/>
-    </record>
 </odoo>

excise_management/data/ir_actions_server.xml

@@ -72,73 +72,28 @@ if from_date < datetime.date.today():
 action = {'view_mode': 'list', 'res_model': 'stock.move', 'type': 'ir.actions.act_window', 'domain': [('id', 'in', record.x_line_ids.mapped('x_move_ids.id'))], 'view_id': env.ref('excise_management.stock_move_view_list').id, 'name': 'Excises Analysis',}
         ]]></field>
     </record>
-    <record id="ir_action_create_excise_report_line" model="ir.actions.server">
-        <field name="code"><![CDATA[
-all_moves_ids = env['stock.move'].search([
-    ('date', '>=', min(records.mapped('x_from_date'), default=datetime.datetime.today())),
-    ('date', '<', max(records.mapped('x_to_date'), default=datetime.datetime.today())),
-    ('x_excise_category', '!=', False),
-    ('x_fiscal_deposit_move', 'not in', ['none', False]),
-    ('state', '=', 'done'),
-])
-for record in records:
-    grouped_data = {}
-    for move in all_moves_ids:
-        if move.date.date() < record.x_from_date or move.date.date() >= record.x_to_date: continue
-        key = (move.x_excise_category.id, move.x_fiscal_deposit_move)
-        if key not in grouped_data: grouped_data[key] = {'qty': 0.0, 'amount': 0.0, 'line_move_ids': []}
-        grouped_data[key]['qty'] += move.x_excise_quantity
-        grouped_data[key]['amount'] += move.x_excise_amount
-        grouped_data[key]['line_move_ids'].append(move.id)
-    lines = env['x_excise_report_line'].create([{
-        'x_excise_category_id': key[0],
-        'x_excise_move_type': key[1],
-        'x_excise_quantity': values['qty'],
-        'x_excise_amount': values['amount'],
-        'x_excise_report_id': record.id,
-        'x_move_ids': [(6, 0, values['line_move_ids'])]
-    } for key, values in grouped_data.items()])
-    record['x_line_ids'] = [(6, 0, lines.ids)] if bool(lines) else [(5, 0, 0)]
-        ]]></field>
+    <record id="ir_action_compute_excise_report_line" model="ir.actions.server">
         <field name="model_id" ref="excise_report"/>
+        <field name="name">Compute excise report line</field>
         <field name="state">code</field>
-        <field name="name">Action to Create Excise Report Line</field>
-        <field name="usage">base_automation</field>
-    </record>
-    <record id="ir_action_update_excise_report_line_onupdate_stock_move" model="ir.actions.server">
         <field name="code"><![CDATA[
-if record['state'] == 'done' and record['x_excise_category'] and record['x_fiscal_deposit_move'] and record['x_fiscal_deposit_move'] != 'none':
-    all_report_ids = env['x_excise_report'].search([])
-    old_report_ids = all_report_ids.filtered(lambda report: report.x_from_date > record['date'].date() or report.x_to_date <= record['date'].date())
-    for report_id in old_report_ids:
-        line_ids = report_id.x_line_ids.filtered(lambda l: l.x_excise_category_id == record['x_excise_category'] and l.x_excise_move_type == record['x_fiscal_deposit_move'] and record.id in l.x_move_ids.ids)
-        for line_id in line_ids:
-            line_id['x_excise_quantity'] -= record['x_excise_quantity'] or 0.0
-            line_id['x_excise_amount'] -= record['x_excise_amount'] or 0.0
-            line_id['x_move_ids'] = [(3, record.id)]
-            if not line_id['x_move_ids']:
-                line_id.unlink()
-    new_report_ids = all_report_ids - old_report_ids
-    for report_id in new_report_ids:
-        line_ids = report_id.x_line_ids.filtered(lambda l: l.x_excise_category_id == record['x_excise_category'] and l.x_excise_move_type == record['x_fiscal_deposit_move'])
-        for line_id in line_ids:
-            if record.id not in line_id.x_move_ids.ids:
-                line_id['x_excise_quantity'] += record['x_excise_quantity'] or 0.0
-                line_id['x_excise_amount'] += record['x_excise_amount'] or 0.0
-                line_id['x_move_ids'] = [(4, record.id)]
-        if not line_ids:
-            env['x_excise_report_line'].create([{
-                'x_excise_category_id': record['x_excise_category'].id,
-                'x_excise_move_type': record['x_fiscal_deposit_move'],
-                'x_excise_quantity': record['x_excise_quantity'],
-                'x_excise_amount': record['x_excise_amount'],
-                'x_excise_report_id': report_id.id,
-                'x_move_ids': [(6, 0, [record.id])]
-            }])
+for record in records:
+    if record.x_state != "done" and record.x_from_date and record.x_to_date:
+        all_moves_ids = env['stock.move']._read_group([
+            ('date', '>=', record.x_from_date),
+            ('date', '<', record.x_to_date),
+            ('x_excise_category', '!=', False), ('x_fiscal_deposit_move', 'not in', ['none', False]), ('state', '=', 'done'),
+        ],
+        groupby=['x_excise_category', 'x_fiscal_deposit_move'],
+        aggregates=['x_excise_quantity:sum', 'x_excise_amount:sum', 'id:recordset']
+        )
+        lines = [env['x_excise_report_line'].create({
+            'x_excise_category_id': move[0].id, 'x_excise_move_type': move[1], 'x_excise_quantity': move[2],
+            'x_excise_amount': move[3], 'x_excise_report_id': record.id, 'x_move_ids': [(6, 0, move[4].ids)],}).id
+            for move in all_moves_ids
+        ]
+        record.write({'x_line_ids': [(6, 0, lines)], 'x_details_computation': True})
+    else: record['x_details_computation'] = False
         ]]></field>
-        <field name="model_id" ref="stock.model_stock_move"/>
-        <field name="state">code</field>
-        <field name="name">Action to Update Excise line</field>
-        <field name="usage">base_automation</field>
     </record>
 </odoo>

excise_management/data/ir_model_fields.xml

@@ -479,6 +479,18 @@ for record in self:
         <field name="model_id" ref="excise_report"/>
         <field name="name">x_document</field>
     </record>
+    <record id="details_computation_excise_report" model="ir.model.fields">
+        <field name="ttype">boolean</field>
+        <field name="field_description">Line Computation</field>
+        <field name="model_id" ref="excise_report"/>
+        <field name="name">x_details_computation</field>
+        <field name="store" eval="False"/>
+        <field name="compute"><![CDATA[
+for record in self:
+    server_action = self.env['ir.actions.server'].browse(self.env.ref('excise_management.ir_action_compute_excise_report_line')).id
+    server_action.with_context(active_ids=[record.id], active_model="x_excise_report").sudo().run()
+        ]]></field>
+    </record>
     <record id="state_excise_report" model="ir.model.fields">
         <field name="name">x_state</field>
         <field name="copied" eval="False"/>
@@ -600,18 +612,6 @@ for rec in self: rec['x_currency_id'] = self.env.company.currency_id.id
         <field name="store" eval="True"/>
         <field name="copied" eval="False"/>
     </record>
-    <record id="excise_report_stock_moves_count" model="ir.model.fields">
-        <field name="compute"><![CDATA[
-for record in self: record['x_move_id_count'] = len(record.x_line_ids.mapped('x_move_ids'))
-    ]]></field>
-        <field name="ttype">integer</field>
-        <field name="field_description">Stock move ID count</field>
-        <field name="model_id" ref="excise_report"/>
-        <field name="name">x_move_id_count</field>
-        <field name="depends">x_line_ids, x_line_ids.x_move_ids</field>
-        <field name="store" eval="False"/>
-        <field name="readonly" eval="True"/>
-    </record>
     <record id="res_company_reporter" model="ir.model.fields">
         <field name="name">x_reporter_id</field>
         <field name="ttype">many2one</field>

excise_management/data/ir_ui_view.xml

@@ -223,9 +223,7 @@
                 </header>
                 <sheet>
                     <div name="button_box" class="oe_button_box">
-                        <button class="oe_stat_button" icon="fa-truck" type="action" name="%(action_excise_report_stock_moves)d">
-                            <field widget="statinfo" name="x_move_id_count" string="Moves"/>
-                        </button>
+                        <button class="oe_stat_button" icon="fa-truck" type="action" name="%(action_excise_report_stock_moves)d" string="Moves" />
                     </div>
                     <div class="oe_title">
                         <h1>
@@ -239,6 +237,7 @@
                         <group>
                             <field name="x_external_id"/>
                             <field name="x_document"/>
+                            <field name="x_details_computation" invisible="1"/>
                         </group>
                     </group>
                     <notebook>

micro_brewery/data/knowledge_article.xml

@@ -310,9 +310,9 @@
 <h3>Excise reporting</h3>
 <p>On top of the legal reporting, you need as well to know at all time the quantity of excise submitted products in your fiscal deposit warehouses.</p>
 <ul>
-    <li><p>Open the <strong>Inventory app</strong> and reach the Excise Reports from the Reporting menu.</p></li>
-    <li><p>Rows come with the same move types detailed as the Excise Reports.</p></li>
-    <li><p>The Total row allows you to capture your currently in fiscal deposit warehouse product quantity!</p></li>
+    <li>Open the <strong>Inventory app</strong> and reach the Excise Reports from the Reporting menu.</li>
+    <li>Rows come with the same move types detailed as the Excise Reports.</li>
+    <li>The Total row allows you to capture your currently in fiscal deposit warehouse product quantity!</li>
 </ul>
 <p>You now have the keys to easily report those to the relevant authorities!</p>
 <p><a href="https://apps.odoo.com/apps/modules/19.0/excise_management" class="btn btn-outline-primary btn-sm" target="_blank">🎓 Excise Management</a></p>

run_industry.sh

@@ -51,8 +51,8 @@ echo "Debug: $DEBUG"
 
 INDUSTRY_PATH="industry/"
 PYTHON_BIN="python3"
-ODOO_BIN="odoo/odoo-bin"
-ADDONS_PATH="$INDUSTRY_PATH/tests,enterprise,odoo/addons,odoo/odoo/addons,design-themes"
+ODOO_BIN="community/odoo-bin"
+ADDONS_PATH="$INDUSTRY_PATH/tests,enterprise,community/addons,community/odoo/addons,design-themes"
 TEST_TAGS="/test_generic,/test_$INDUSTRY_NAME"
 DEP_DB="dep-$INDUSTRY_NAME"