19.0 condominium industry update mega #1346

mega-odoo · 2025-11-13T10:51:19Z

Purpose: Rework of the industry based on feedback, as well as to generate more traction on the combo of industries real estate, estate management, and condominium

This commit adds new features to the condominium module, including managing co-ownership properties, Split analytic items in case of owner change, general meeting animation with votes, delegation, and report, and improving the report for the general meetings agenda and report. Added Building tab and fields to the contact form, captures the history of owners and tenants

Rework on Contacts, Condominium app, Accounts, Calendar events, Invoices, Distribution key, and Automations

TASK-4743607

- dumy commit .

- split account.analytoic.line wizard

- change a sequence

- demo

- cleans fields.xml

- changes in ir_ui_view.

- adjust companies data.

- Add projects, tasks documents.

- chnage a company for builinds. - change in calender

robodoo · 2025-11-13T10:51:23Z

pgu-odoo

@mega-odoo A few suggestions are here. Thanks.

pgu-odoo · 2025-11-26T09:48:02Z

condominium/data/ir_actions_server.xml

+analytic_account = env['account.analytic.account']
+for line in property_id.x_owner_ids:
+    owner = line.x_owner
+    owner_id = owner.id


Suggested change

owner_id = owner.id

use owner.id whenever needed.

pgu-odoo · 2025-11-27T05:10:21Z

condominium/data/ir_model_fields.xml

+    <field name="name">x_condominium_account_analytic_account_count</field>
+    <field name="compute"><![CDATA[
+for record in self:
+    record['x_condominium_account_analytic_account_count'] = self.env['account.analytic.account'].search_count([('partner_id', '=', record.id)])


Instead of search_count in for loop. You can user read_group method.

pgu-odoo · 2025-11-27T05:11:53Z

condominium/data/ir_model_fields.xml

+    <field name="field_description">Source Sales Order count</field>
+    <field name="compute"><![CDATA[
+for record in self:
+    record['x_source_sales_order_sale_order_count'] = self.env['sale.order'].search_count([('x_source_sales_order', 'in', record.ids)])


same as above. Using read_group is better.

pgu-odoo · 2025-11-27T05:15:28Z

condominium/data/ir_model_fields.xml

+    accounts = self.env['account.analytic.account'].search([('partner_id','=',record.x_owner),('x_property','=',record.x_property),('x_end_date','=',False)])
+    record['x_account'] = accounts.id]]></field>


what if search returns multiple analytic accounts? accounts.id will break.
if you want only one analytic account, use the limit=1 in search and change the name account from accounts.
if expecting multiple, then handle the assignation proper.

pgu-odoo · 2025-11-27T05:28:19Z

condominium/data/ir_model_fields.xml

+    <field name="compute"><![CDATA[for record in self:
+    is_distributed = False
+    for invoice_line in record.invoice_line_ids:
+        if invoice_line.analytic_distribution != False: 
+            is_distributed = True
+            break
+    record['x_is_distributed'] = is_distributed]]></field>


for record in self: record.x_is_distributed = any( bool(line.analytic_distribution) for line in record.invoice_line_ids )

would be better

pgu-odoo · 2025-11-27T06:27:55Z

condominium/data/ir_ui_view.xml

+                  <field optional="show" name="x_end_date"/>
+                  <field optional="show" name="x_owner" required="True" widget="many2one_avatar_user"/>
+                  <field optional="show" name="x_co_owners" widget="many2many_tags_avatar"/>
+                  <field optional="show" name="x_account" options="{&quot;no_create&quot;:true}" readonly="True" widget="many2one_tax_tags" column_invisible="True"/>


Suggested change

<field optional="show" name="x_account" options="{"no_create":true}" readonly="True" widget="many2one_tax_tags" column_invisible="True"/>

<field optional="show" name="x_account" options="{'no_create':true}" readonly="True" widget="many2one_tax_tags" column_invisible="True"/>

pgu-odoo · 2025-11-27T06:29:02Z

condominium/data/ir_ui_view.xml

+              <field name="x_owner_ids">
+                <list editable="top">
+                  <field name="x_sequence" widget="handle"/>
+                  <field optional="show" name="x_start_date" required="True"/>


if it is required, we should not put it in optional="show"

pgu-odoo · 2025-11-27T07:03:33Z

condominium/data/ir_ui_view.xml

+    <field name="name">x_period.form.condominium</field>
+    <field name="type">form</field>
+  </record>
+  <record id="default_search_view__357f8b9e-0127-48a6-97ac-45ad1fce0030" model="ir.ui.view">


Suggested change

<record id="default_search_view__357f8b9e-0127-48a6-97ac-45ad1fce0030" model="ir.ui.view">

<record id="default_search_view" model="ir.ui.view">

pgu-odoo · 2025-11-27T07:14:08Z

condominium/data/ir_ui_view.xml

+    <field name="arch" type="xml">
+      <form>
+        <header>
+          <button string="Populate" name="%(action_populate_distribution_key)d" type="action" class="btn-primary" invisible="x_based_on != &quot;Shares&quot;"/>


Suggested change

<button string="Populate" name="%(action_populate_distribution_key)d" type="action" class="btn-primary" invisible="x_based_on != "Shares""/>

<button string="Populate" name="%(action_populate_distribution_key)d" type="action" class="btn-primary" invisible="x_based_on != 'Shares'"/>

pgu-odoo · 2025-12-01T04:24:12Z

condominium/data/qweb_view.xml

+		<field name="key">condominium.report_calendar_event_general_meeting_document</field>
+		<field name="active" eval="True" />
+		<field name="name">condominium.report_calendar_event_general_meeting_document</field>
+		<field name="priority">9999999</field>


is it needed?

pgu-odoo · 2025-12-01T08:47:56Z

@vava-odoo I have given a few suggestions and @mega-odoo is working with those but I think meanwhile you can also start the code review for this PR.

Thanks

mega-odoo · 2025-12-03T05:26:20Z

@vava-odoo I have given a few suggestions and @mega-odoo is working with those but I think meanwhile you can also start the code review for this PR.

Thanks

The changes have been made according to your suggestions,

Thank you :)

mega-odoo added 29 commits November 6, 2025 15:18

Cleanup commit -1

717bc29

- dumy commit .

split analytic item -2

34d4aee

- split account.analytoic.line wizard

Cleanup commit -3

703e795

- change a sequence

Cleanup commit -4

3050f68

- demo

Cleanup commit -5

ff7db36

- cleans fields.xml

Cleanup commit -6

90b452c

- changes in ir_ui_view.

Cleanup 23july

c9448be

- adjust companies data.

Cleanup 25 july

9d17847

- Add projects, tasks documents.

Cleanup 29 july

9a818ca

Cleanup 29

6e06d1e

- chnage a company for builinds. - change in calender

[IMP] condominium: remarks

233ae40

[IMP] condominium: cleanup11

456fee6

[IMP] condominium: cleanup12

ab2aa28

[IMP] condominium: cleanup13

1a99f65

[IMP] condominium: cleanup14

eaff2ed

[IMP] condominium: cleanup15

6461b30

[IMP] condominium: cl-17

ba50aa1

[IMP] condominium: cl-18 rename accounts

f4695f5

[IMP] condominium: cl-19

b913373

[IMP] condominium: cl-20

1177223

[IMP] condominium: cl-21 rename record id

b198cf1

[IMP] condominium: cl-22 rename property line model

90788c9

[IMP] condominium: cl-23 merge view

2cc1c84

[IMP] condominium: cl-24 remove extra records and fields

b41ec94

[IMP] condominium: cl-25 remove studio

eb29b61

[IMP] condominium: cl-26 x_studio_property to x_property

16b23ef

[IMP] condominium: cl-27 rename calender line

a79a149

[IMP] condominium: cl-28 remove unused records

6f01bbb

[IMP] condominium: cl-29 remove comment data

72f3aa7

mega-odoo force-pushed the 19.0-condominium-industry-v3-update-mega branch from 6404157 to 0d2b4a7 Compare November 21, 2025 13:22

[IMP] condominium: cl-33

8e71bc0

mega-odoo force-pushed the 19.0-condominium-industry-v3-update-mega branch 5 times, most recently from 419996b to 024ab79 Compare November 25, 2025 10:15

[IMP] condominium: cl-34

3dd8a67

mega-odoo force-pushed the 19.0-condominium-industry-v3-update-mega branch 9 times, most recently from 3761e53 to 17d7462 Compare November 26, 2025 07:28

[IMP] condominium: cl-35

33eb5ef

mega-odoo force-pushed the 19.0-condominium-industry-v3-update-mega branch from 17d7462 to 33eb5ef Compare November 26, 2025 09:53

pgu-odoo reviewed Dec 1, 2025

View reviewed changes

mega-odoo force-pushed the 19.0-condominium-industry-v3-update-mega branch 5 times, most recently from 64ace55 to d0eacec Compare December 2, 2025 06:53

[IMP] condominium: cl-36

f63ac54

mega-odoo force-pushed the 19.0-condominium-industry-v3-update-mega branch from d0eacec to f63ac54 Compare December 2, 2025 07:21

[IMP] condominium: cl-37

1679d01

		accounts = self.env['account.analytic.account'].search([('partner_id','=',record.x_owner),('x_property','=',record.x_property),('x_end_date','=',False)])
		record['x_account'] = accounts.id]]></field>

	<field optional="show" name="x_account" options="{"no_create":true}" readonly="True" widget="many2one_tax_tags" column_invisible="True"/>
	<field optional="show" name="x_account" options="{'no_create':true}" readonly="True" widget="many2one_tax_tags" column_invisible="True"/>

	<record id="default_search_view__357f8b9e-0127-48a6-97ac-45ad1fce0030" model="ir.ui.view">
	<record id="default_search_view" model="ir.ui.view">

	<button string="Populate" name="%(action_populate_distribution_key)d" type="action" class="btn-primary" invisible="x_based_on != "Shares""/>
	<button string="Populate" name="%(action_populate_distribution_key)d" type="action" class="btn-primary" invisible="x_based_on != 'Shares'"/>

19.0 condominium industry update mega #1346

Are you sure you want to change the base?

19.0 condominium industry update mega #1346

Uh oh!

Conversation

mega-odoo commented Nov 13, 2025

Uh oh!

robodoo commented Nov 13, 2025

Uh oh!

pgu-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pgu-odoo commented Dec 1, 2025

Uh oh!

mega-odoo commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants