[IMP] calendar chart: automatically detect calendar chart

If a chart is created on a dataset with dates in the first column
and numbers in the second column, we should create a calendar chart
by default.

Task: 5357420

Author: hokolomopo

src/helpers/figures/charts/smart_chart_engine.ts

@@ -165,7 +165,7 @@ function buildSingleColumnChart(column: ColumnInfo, getters: Getters): ChartDefi
  * columns left to right, and is as follows:
  * - any type + percentage columns: pie chart
  * - number + number columns: scatter chart
- * - date + number columns: line chart
+ * - date + number columns: calendar chart
  * - text + number columns: treemap if repetition in labels
  * - any other combination: bar chart
  */
@@ -198,14 +198,16 @@ function buildTwoColumnChart(columns: ColumnInfo[], getters: Getters): ChartDefi
     };
   }
 
-  // TODO: Handle date + number with calendar chart when implemented (and change the docstring)
   if (columns[0].type === "date" && columns[1].type === "number") {
     return {
-      ...DEFAULT_LINE_CHART_CONFIG,
-      type: "line",
+      type: "calendar",
       dataSets: [{ dataRange: getUnboundRange(getters, columns[1].zone) }],
       labelRange: getUnboundRange(getters, columns[0].zone),
       dataSetsHaveTitle: isDatasetTitled(getters, columns[0]),
+      title: {},
+      legendPosition: "none",
+      horizontalGroupBy: "day_of_week",
+      verticalGroupBy: "month_number",
     };
   }
 

tests/figures/chart/menu_item_insert_chart.test.ts

@@ -502,7 +502,7 @@ describe("Smart chart type detection", () => {
     [["number", "percentage"], { type: "pie" }],
     [["date", "percentage"], { type: "pie" }],
     [["number", "number"], { type: "scatter" }],
-    [["date", "number"], { type: "line" }],
+    [["date", "number"], { type: "calendar" }],
     [["text", "number"], { type: "bar" }],
     [["text_repeated", "number"], { type: "treemap" }],
     [["text", "date"], { type: "bar" }],