[FIX] GenericInput: skip focus manipulation

When providing the props `selectContentOnFocus`, we manipulate the
default behaviour of the browser (mouseDown/mouseUp) to select the full
content of the input. However, half of this manipulation (prevent mouseDown
default) still occured even if the props `selectContentOnFocus` was
set to false.

Unfortunately, this cannot be properly tested as the update of the
selected range on mouseDown does not seem programatically reproductible.

closes #7383

Task: 5206980
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>

Author: rrahir

src/components/generic_input/generic_input.ts

@@ -83,15 +83,15 @@ export class GenericInput<T extends GenericInputProps> extends Component<T, Spre
 
   onMouseDown(ev: MouseEvent) {
     // Stop the event if the input is not focused, we handle everything in onMouseUp
-    if (ev.target !== document.activeElement) {
+    if (ev.target !== document.activeElement && this.props.selectContentOnFocus) {
       ev.preventDefault();
       ev.stopPropagation();
     }
   }
 
   onMouseUp(ev: MouseEvent) {
     const target = ev.target as HTMLInputElement;
-    if (target !== document.activeElement) {
+    if (target !== document.activeElement && this.props.selectContentOnFocus) {
       target.focus();
       if (this.props.selectContentOnFocus) {
         target.select();