Skip to content

Conversation

@hokolomopo
Copy link
Contributor

Description:

[FIX] calendar chart: hide scales borders

The calendar chart grid lines aren't shown, but the borders between
chartArea and the ticks labels was still shown. Depending on the
screen, zoom, and size of the chart, the border would be more or less
visible. This commit hides these borders.

[IMP] demo: add calender chart demo data

[FIX] calendar chart: fix typing

The type CalendarChartGranularity would accept granularities that
are only valid for pivots and not for calendar charts.

[IMP] calendar chart: automatically detect calendar chart

If a chart is created on a dataset with dates in the first column
and numbers in the second column, we should create a calendar chart
by default.

Task: 5357420

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Nov 25, 2025

Pull request status dashboard

If a chart is created on a dataset with dates in the first column
and numbers in the second column, we should create a calendar chart
by default.

Task: 5357420
The type `CalendarChartGranularity` would accept granularities that
are only valid for pivots and not for calendar charts.

Task: 5357420
The calendar chart grid lines aren't shown, but the borders between
chartArea and the ticks labels was still shown. Depending on the
screen, zoom, and size of the chart, the border would be more or less
visible. This commit hides these borders.

Task: 5357420
@hokolomopo hokolomopo force-pushed the master-smart-chart-calendar-adrm branch from 461fa33 to d6582eb Compare November 25, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants