[IMP] Pivot: added a check in the allowdispatch #7573
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
Spec : Currently, one could dispatch the command ADD_PIVOT by specifying a pivotId which corresponds to an already existing pivot. This is quite error prone as it could lead to a situation where we erase an existing PIVOT by mistake. The goal is to prevent this kind of situation by adding a check in the allowDispatch of the core plugin Pivot which should reject the command ADD_PIVOT if it targets an already exisitng pivot (similarly to the check done for the command INSERT_PIVOT). Task: 5360591
matho-odoo
force-pushed
the
master-allowdispatch-addpivot-matho
branch
from
bd26a99 to
a08d406
Compare
robodoo
pushed a commit
that referenced
this pull request
Dec 4, 2025
Spec : Currently, one could dispatch the command ADD_PIVOT by specifying a pivotId which corresponds to an already existing pivot. This is quite error prone as it could lead to a situation where we erase an existing PIVOT by mistake. The goal is to prevent this kind of situation by adding a check in the allowDispatch of the core plugin Pivot which should reject the command ADD_PIVOT if it targets an already exisitng pivot (similarly to the check done for the command INSERT_PIVOT). closes #7573 Task: 5360591 Signed-off-by: Pierre Rousseau (pro) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
prevent the override of existing pivots through ADD_PIVOT. command
Task: 5360591
review checklist