wip OLS01007

Author: fda-odoo

server/src/core/file_mgr.rs

@@ -89,6 +89,8 @@ pub struct FileInfo {
     pub noqas_blocs: HashMap<u32, NoqaInfo>,
     noqas_lines: HashMap<u32, NoqaInfo>,
     diagnostic_filters: Vec<DiagnosticFilter>,
+
+    pub diag_test_comments: Vec<(u32, Vec<String>)>, //for tests: line and list of codes
 }
 
 impl FileInfo {
@@ -109,6 +111,7 @@ impl FileInfo {
             noqas_blocs: HashMap::new(),
             noqas_lines: HashMap::new(),
             diagnostic_filters: Vec::new(),
+            diag_test_comments: vec![],
         }
     }
     pub fn update(&mut self, session: &mut SessionInfo, uri: &str, content: Option<&Vec<TextDocumentContentChangeEvent>>, version: Option<i32>, in_workspace: bool, force: bool) -> bool {
@@ -191,7 +194,7 @@ impl FileInfo {
         if in_workspace {
             self.noqas_blocs.clear();
             self.noqas_lines.clear();
-            self.extract_tokens(&parsed_module, &source);
+            self.extract_tokens(&parsed_module, &source, session.sync_odoo.test_mode);
         }
         self.valid = true;
         for error in parsed_module.errors().iter() {
@@ -229,7 +232,7 @@ impl FileInfo {
         self._build_ast(session, session.sync_odoo.get_file_mgr().borrow().is_in_workspace(&self.uri));
     }
 
-    pub fn extract_tokens(&mut self, parsed_module: &Parsed<ModModule>, source: &String) {
+    pub fn extract_tokens(&mut self, parsed_module: &Parsed<ModModule>, source: &String, parse_test_comments: bool) {
         let mut is_first_expr: bool = true;
         let mut noqa_to_add = None;
         let mut previous_token: Option<&Token> = None;
@@ -269,6 +272,14 @@ impl FileInfo {
                             }
                         }
                     }
+                    if parse_test_comments {
+                        if text.starts_with("#OLS") || text.starts_with("# OLS") {
+                            let codes = text.split(",").map(|s| s.trim().trim_start_matches('#').trim().to_string()).collect::<Vec<String>>();
+                            let char = self.file_info_ast.borrow().text_rope.as_ref().unwrap().try_byte_to_char(token.start().to_usize()).expect("unable to get char from bytes");
+                            let line = self.file_info_ast.borrow().text_rope.as_ref().unwrap().try_char_to_line(char).ok().expect("unable to get line from char");
+                            self.diag_test_comments.push((line as u32, codes));
+                        }
+                    }
                 },
                 TokenKind::Class | TokenKind::Def => {
                     if noqa_to_add.is_some() {

server/src/core/odoo.rs

@@ -95,6 +95,8 @@ pub struct SyncOdoo {
     pub import_cache: Option<ImportCache>,
     pub capabilities: lsp_types::ClientCapabilities,
     pub opened_files: Vec<String>,
+
+    pub test_mode: bool,
 }
 
 unsafe impl Send for SyncOdoo {}
@@ -137,6 +139,8 @@ impl SyncOdoo {
             import_cache: None,
             capabilities: lsp_types::ClientCapabilities::default(),
             opened_files: vec![],
+
+            test_mode: false,
         };
         sync_odoo
     }

server/tests/data/python/diagnostics/ols01007.py

@@ -0,0 +1,143 @@
+def a():
+    pass
+
+a()
+a(5) #OLS01007
+
+def b(value):
+    pass
+
+b() # OLS01007
+b(10)
+
+def c(x = 7):
+    pass
+
+c()
+c(5)
+c(5, 9) # OLS01007
+
+def d(x, y=0):
+    pass
+
+d() # OLS01007
+d(5)
+d(5, 6)
+d(5, 6, 7) # OLS01007
+
+def e(*args):
+    pass
+
+e()
+e(1)
+e(1, 2, 3)
+
+def f(x, *args):
+    pass
+
+f() # OLS01007
+f(1)
+f(1, 2)
+f(1, 2, 3)
+
+def g(x, y, *args):
+    pass
+
+g() # OLS01007
+g(1) # OLS01007
+g(1, 2)
+g(1, 2, 3)
+g(1, 2, 3, 4)
+
+def h(x, y=10, *args):
+    pass
+
+h() # OLS01007
+h(1)
+h(1, 2)
+h(1, 2, 3)
+
+def i(x, y, z=0):
+    pass
+
+i() # OLS01007
+i(1) # OLS01007
+i(1, 2)
+i(1, 2, 3)
+i(1, 2, 3, 4) # OLS01007
+
+# Position-only parameters (Python 3.8+)
+def j(x, y, /):
+    pass
+
+j(1, 2)
+j(1) # OLS01007
+j(x=1, y=2) # OLS01007 (positional-only)
+j(1, 2, 3) # OLS01007
+
+def k(x, /, y, z=0):
+    pass
+
+k(1, 2)
+k(1, 2, 3)
+k(1) # OLS01007
+k(1, 2, 3, 4) # OLS01007
+k(x=1, y=2) # OLS01007
+
+# Keyword-only parameters (after a bare *)
+def l(*, x):
+    pass
+
+l(x=1)
+l() # OLS01007
+l(1) # OLS01007
+
+def m(a, *, x, y=3):
+    pass
+
+m(1, x=2)
+m(1, x=2, y=4)
+m(1) # OLS01007
+m(1, 2) # OLS01007
+
+# Mixed positional-only + regular + keyword-only
+def n(a, b, /, c, *, d, e=0):
+    pass
+
+n(1, 2, 3, d=4)
+n(1, 2, 3, d=4, e=5)
+n(1, 2, c=3, d=4)
+n(a=1, b=2, c=3, d=4) # OLS01007 (a/b positional-only)
+n(1, 2) # OLS01007
+n(1, 2, 3) # OLS01007 (missing keyword-only d)
+n(1, 2, 3, 4, d=5) # OLS01007 (too many positional arguments)
+
+# Functions mixing defaults and varargs + keywords
+def o(a, b=1, *args, c, d=0):
+    pass
+
+o(1, c=2)
+o(1, 2, c=3)
+o(1, 2, 3, 4, c=5)
+o() # OLS01007
+o(1) # OLS01007 (missing c)
+o(1, 2, 3, d=5) # OLS01007 (missing c)
+o(1, 2, c=3, 5) # OLS01000 (positional after keyword)
+
+# Fully variadic keyword-only
+def p(**kwargs):
+    pass
+
+p()
+p(x=1, y=2)
+
+# Positional + keyword-only interaction
+def q(a, b, *, x, y=10):
+    pass
+
+q(1, 2, x=3)
+q(1, 2, x=3, y=4)
+q(1, 2) # OLS01007
+q(1, 2, 3) # OLS01007
+q(a=1, b=2, x=3) # valid
+q(a=1, b=2, 3) # OLS01000 (positional after keyword)

server/tests/diagnostics/mod.rs

@@ -6,3 +6,4 @@ pub mod ols01003;
 pub mod ols01004;
 pub mod ols01005;
 pub mod ols01006;
+pub mod ols01007;

server/tests/diagnostics/ols01007.rs

@@ -0,0 +1,5 @@
+
+#[test]
+fn test_ols01007() {
+    panic!("Not implemented yet");
+}