[IMP] util/{domains,fields}: replace fields in server actions' update_path

`update_path` is used by server actions to know what field to update. It
needs to be updated when renaming fields.

closes #53

Signed-off-by: Christophe Simonis (chs) <[email protected]>

Author: aj-fuentes

src/util/domains.py

@@ -1,5 +1,6 @@
 # -*- coding: utf-8 -*-
 import collections
+import functools
 import logging
 import re
 
@@ -174,6 +175,21 @@ def _valid_path_to(cr, path, from_, to):
     return model is not None and model == to
 
 
+def _replace_path(cr, old, new, src_model, dst_model, path_str):
+    """
+    Replace `old` by `new` in the fields path `path_str` assuming the path starts from `src_model`.
+    The replace only takes place if `old` points at `dst_model`.
+    """
+    dot_old = old.split(".")
+    dot_new = new.split(".")
+    path = path_str.split(".")
+    for idx in range(len(path) - len(dot_old), -1, -1):
+        r = slice(idx, idx + len(dot_old))
+        if path[r] == dot_old and _valid_path_to(cr, path[:idx], src_model, dst_model):
+            path[r] = dot_new
+    return ".".join(path)
+
+
 def _adapt_one_domain(cr, target_model, old, new, model, domain, adapter=None, force_adapt=False):
     if not adapter:
         adapter = lambda leaf, _, __: [leaf]
@@ -197,15 +213,7 @@ def _adapt_one_domain(cr, target_model, old, new, model, domain, adapter=None, f
             return None
 
     dot_old = old.split(".")
-    dot_new = new.split(".")
-
-    def clean_path(left):
-        path = left.split(".")
-        for idx in range(len(path) - len(dot_old), -1, -1):
-            r = slice(idx, idx + len(dot_old))
-            if path[r] == dot_old and _valid_path_to(cr, path[:idx], model, target_model):
-                path[r] = dot_new
-        return ".".join(path)
+    clean_path = functools.partial(_replace_path, cr, old, new, model, target_model)
 
     def clean_term(term):
         if isinstance(term, basestring) or not isinstance(term[0], basestring):

src/util/fields.py

@@ -7,6 +7,7 @@
 
 import psycopg2
 from psycopg2 import sql
+from psycopg2.extras import Json
 
 try:
     from odoo import release
@@ -28,7 +29,7 @@ def make_index_name(table_name, column_name):
 
 
 from .const import ENVIRON
-from .domains import _adapt_one_domain, _valid_path_to, adapt_domains
+from .domains import _adapt_one_domain, _replace_path, _valid_path_to, adapt_domains
 from .exceptions import SleepyDeveloperError
 from .helpers import _dashboard_actions, _validate_model, table_of_model
 from .inherit import for_each_inherit
@@ -855,6 +856,32 @@ def _update_field_usage_multi(cr, models, old, new, domain_adapter=None, skip_in
     }
 
     # ir.action.server
+    if column_exists(cr, "ir_act_server", "update_path") and only_models:
+        cr.execute(
+            """
+            SELECT a.id,
+                   a.update_path,
+                   m.model
+              FROM ir_act_server a
+              JOIN ir_model m
+                ON a.model_id = m.id
+             WHERE a.state = 'object_write'
+               AND a.update_path ~ %(old)s
+            """,
+            p,
+        )
+        to_update = {}
+        for act_id, update_path, src_model in cr.fetchall():
+            for dst_model in only_models:
+                new_path = _replace_path(cr, old, new, src_model, dst_model, update_path)
+                if new_path != update_path:
+                    to_update[act_id] = new_path
+        if to_update:
+            cr.execute(
+                "UPDATE ir_act_server SET update_path = %s::jsonb->>id::text WHERE id IN %s",
+                [Json(to_update), tuple(to_update)],
+            )
+
     # Modifying server action is dangerous.
     # The search pattern can be anywhere in the code, leading to invalid codes.
     # Moreover, limiting to some models will ignore some SA that should be modified.