[chore] pre-commit autoupdate

Also fix new ruff violations

closes #102

Related: odoo/upgrade#6192
Signed-off-by: Christophe Simonis (chs) <[email protected]>

Author: KangOl

.pre-commit-config.yaml

@@ -12,15 +12,15 @@ repos:
         files: '^src/\w+/(tests|0\.0\.0)/.*\.py$'
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.3.0
+    rev: v0.5.0
     hooks:
     - id: ruff
       name: Check code with Ruff, apply automatic fixes
       args: [ --exit-non-zero-on-fix ]
     - id: ruff-format
       name: Format code with Ruff
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v4.5.0
+    rev: v4.6.0
     hooks:
     - id: check-xml
     - id: check-yaml

src/base/17.0.1.3/attr_domains2expr.py

@@ -187,9 +187,7 @@ def find_target(elem):
 def is_simple_pred(expr):
     if expr in ("0", "1", "True", "False"):
         return True
-    if re.match(r"""context\.get\((['"])\w+\1\)""", expr):
-        return True
-    return False
+    return bool(re.match(r"""context\.get\((['"])\w+\1\)""", expr))
 
 
 def fix_elem(cr, model, elem, comb_arch):
@@ -455,7 +453,7 @@ def convert_attrs_val(cr, model, field_path, val):
         )
     if isinstance(val, ast.BoolOp):
         return "({})".format(
-            (" and " if type(val.op) == ast.And else " or ").join(
+            (" and " if type(val.op) is ast.And else " or ").join(
                 convert_attrs_val(cr, model, field_path, v) for v in val.values
             )
         )

src/util/domains.py

@@ -368,7 +368,7 @@ def adapter(leaf, in_or, negated):
         """.format(df=df),
             [match_old],
         )
-        for id_, model, domain in cr.fetchall():
+        for id_, model, domain in cr.fetchall():  # noqa: PLR1704
             new_domain = _adapt_one_domain(
                 cr, target_model, old, new, model, domain, adapter=adapter, force_adapt=force_adapt
             )

src/util/fields.py

@@ -1211,11 +1211,11 @@ def adapt_depends(cr, model, old, new, skip_inherit=()):
         """,
         [match_old],
     )
-    for id_, model, depends in cr.fetchall():
+    for id_, field_model, depends in cr.fetchall():
         temp_depends = depends.split(",")
         for i in range(len(temp_depends)):
             domain = _adapt_one_domain(
-                cr, target_model, old, new, model, [(temp_depends[i], "=", "depends")], force_adapt=True
+                cr, target_model, old, new, field_model, [(temp_depends[i], "=", "depends")], force_adapt=True
             )
             if domain:
                 temp_depends[i] = domain[0][0]
@@ -1246,8 +1246,10 @@ def adapt_related(cr, model, old, new, skip_inherit=()):
         """,
         [match_old],
     )
-    for id_, model, related in cr.fetchall():
-        domain = _adapt_one_domain(cr, target_model, old, new, model, [(related, "=", "related")], force_adapt=True)
+    for id_, field_model, related in cr.fetchall():
+        domain = _adapt_one_domain(
+            cr, target_model, old, new, field_model, [(related, "=", "related")], force_adapt=True
+        )
         if domain:
             cr.execute("UPDATE ir_model_fields SET related = %s WHERE id = %s", [domain[0][0], id_])
 

src/util/pg.py

@@ -96,10 +96,10 @@ def _parallel_execute_threaded(cr, queries, logger=_logger):
         cursor = db_connect(cr.dbname).cursor
 
         def execute(query):
-            with cursor() as cr:
-                cr.execute(query)
-                cnt = cr.rowcount
-                cr.commit()
+            with cursor() as tcr:
+                tcr.execute(query)
+                cnt = tcr.rowcount
+                tcr.commit()
                 return cnt
 
         cr.commit()

src/util/records.py

@@ -1147,9 +1147,9 @@ def delete_unused(cr, *xmlids, **kwargs):
     )
 
     deleted = []
-    for model, ids, xmlids in cr.fetchall():
+    for model, ids, xids in cr.fetchall():
         table = table_of_model(cr, model)
-        res_id_to_xmlid = dict(zip(ids, xmlids))
+        res_id_to_xmlid = dict(zip(ids, xids))
 
         sub = " UNION ".join(
             [