Skip to content

Commit ac8138e

Browse files
Bump mypy from 1.18.2 to 1.19.0 in /requirements/lintrunner (#261)
1 parent c2ae2c7 commit ac8138e

File tree

3 files changed

+13
-11
lines changed

3 files changed

+13
-11
lines changed

requirements/lintrunner/requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ lintrunner-adapters>=0.8.0
33
# RUFF, RUFF-FIX
44
ruff==0.14.8
55
# MYPY
6-
mypy==1.18.2
6+
mypy==1.19.0
77
types-PyYAML==6.0.12.20250822
88
# EDITORCONFIG-CHECKER
99
editorconfig-checker==3.4.1

src/onnx_ir/passes/common/inliner.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,11 +258,13 @@ def _instantiate_call(self, node: ir.Node, call_site_id: CallSiteId) -> NodeRepl
258258

259259
def rename(node: ir.Node) -> None:
260260
"""Rename node/values in inlined node to ensure uniqueness in the inlined context."""
261-
node.name = _make_unique_name(node.name, new_call_stack, self.used_node_names)
261+
node_name = node.name or "node"
262+
node.name = _make_unique_name(node_name, new_call_stack, self.used_node_names)
262263
for output in node.outputs:
263264
if output is not None:
265+
output_name = output.name or "val"
264266
output.name = _make_unique_name(
265-
output.name, new_call_stack, self.used_value_names
267+
output_name, new_call_stack, self.used_value_names
266268
)
267269
# Update context in case the new node is itself a call node that will be inlined.
268270
self.node_context[node] = new_call_stack

src/onnx_ir/passes/common/naming.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,8 @@ def _fix_graph_names(self, graph_like: ir.Graph | ir.Function) -> bool:
107107
scoped_used_node_names: list[set[str]] = [set()]
108108

109109
# Counters for generating unique names (using list to pass by reference)
110-
value_counter = collections.Counter()
111-
node_counter = collections.Counter()
110+
value_counter: collections.Counter[str] = collections.Counter()
111+
node_counter: collections.Counter[str] = collections.Counter()
112112

113113
def enter_graph(graph_like) -> None:
114114
"""Callback for entering a subgraph."""
@@ -182,7 +182,7 @@ def _process_value(
182182
value: ir.Value,
183183
used_value_names: set[str],
184184
seen_values: set[ir.Value],
185-
value_counter: collections.Counter,
185+
value_counter: collections.Counter[str],
186186
) -> bool:
187187
"""Process a value only if it hasn't been processed before."""
188188
if value in seen_values:
@@ -202,7 +202,7 @@ def _process_value(
202202
return modified
203203

204204
def _assign_value_name(
205-
self, value: ir.Value, used_names: set[str], counter: collections.Counter
205+
self, value: ir.Value, used_names: set[str], counter: collections.Counter[str]
206206
) -> bool:
207207
"""Assign a name to an unnamed value. Returns True if modified."""
208208
assert not value.name, (
@@ -215,7 +215,7 @@ def _assign_value_name(
215215
return True
216216

217217
def _assign_node_name(
218-
self, node: ir.Node, used_names: set[str], counter: collections.Counter
218+
self, node: ir.Node, used_names: set[str], counter: collections.Counter[str]
219219
) -> bool:
220220
"""Assign a name to an unnamed node. Returns True if modified."""
221221
assert not node.name, (
@@ -228,7 +228,7 @@ def _assign_node_name(
228228
return True
229229

230230
def _fix_duplicate_value_name(
231-
self, value: ir.Value, used_names: set[str], counter: collections.Counter
231+
self, value: ir.Value, used_names: set[str], counter: collections.Counter[str]
232232
) -> bool:
233233
"""Fix a value's name if it conflicts with existing names. Returns True if modified."""
234234
original_name = value.name
@@ -249,7 +249,7 @@ def _fix_duplicate_value_name(
249249
return True
250250

251251
def _fix_duplicate_node_name(
252-
self, node: ir.Node, used_names: set[str], counter: collections.Counter
252+
self, node: ir.Node, used_names: set[str], counter: collections.Counter[str]
253253
) -> bool:
254254
"""Fix a node's name if it conflicts with existing names. Returns True if modified."""
255255
original_name = node.name
@@ -269,7 +269,7 @@ def _fix_duplicate_node_name(
269269

270270

271271
def _find_and_record_next_unique_name(
272-
preferred_name: str, used_names: set[str], counter: collections.Counter
272+
preferred_name: str, used_names: set[str], counter: collections.Counter[str]
273273
) -> str:
274274
"""Generate a unique name based on the preferred name and current counter."""
275275
new_name = preferred_name

0 commit comments

Comments
 (0)