Skip to content

Support rollback for ManifestWorkReplicaSet #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Dec 3, 2025
Merged

Support rollback for ManifestWorkReplicaSet #164

openshift-merge-bot merged 1 commit into from
Dec 3, 2025

Conversation

@youngbupark
Copy link
Contributor

@youngbupark youngbupark commented Nov 12, 2025

  • Support rollback for ManifestWorkReplicaSet

@youngbupark youngbupark marked this pull request as ready for review November 12, 2025 05:43
@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 November 12, 2025 05:43
youngbupark
youngbupark commented Nov 12, 2025
View reviewed changes
enhancements/sig-architecture/229-manifestworkreplicaset-rollback/README.md Outdated

## Design Details

The `abort` operation cancels the progressing rollout and rolls it back to the stable revision automatically without updating `.spec.manifestWorkTemplate`, whereas `rollback` requires explicit manual action by updating `.spec.manifestWorkTemplate`.
Copy link
Contributor Author

@youngbupark youngbupark Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am following the same concept of abort and rollback of argo rollout. See this - https://argo-rollouts.readthedocs.io/en/stable/getting-started/#4-aborting-a-rollout

youngbupark
youngbupark commented Nov 12, 2025
View reviewed changes
enhancements/sig-architecture/229-manifestworkreplicaset-rollback/README.md

### ManifestWorkReplicaSet API Object

To support abort and rollback feature, we will have the following API changes:
Copy link
Contributor Author

@youngbupark youngbupark Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if I need to split the enhancement for rollback and abort features.

youngbupark
youngbupark commented Nov 12, 2025
View reviewed changes
enhancements/sig-architecture/229-manifestworkreplicaset-rollback/README.md Outdated

## Summary

This enhancement proposes adding rollback capabilities to ManifestWorkReplicaSet (MWRS) to enable safe recovery from failed multi-cluster deployments. The solution leverages Kubernetes ControllerRevision resources to maintain a historical record of MWRS template changes, similar to how StatefulSet and DaemonSet controllers track revision history.
Copy link
Contributor Author

@youngbupark youngbupark Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the plugin enhancment proposal after this proposal is approved - #160 I would rename rollback to abort in plugin hook name.

haoqing0110
haoqing0110 reviewed Nov 12, 2025
View reviewed changes
annelaucg
annelaucg reviewed Nov 13, 2025
View reviewed changes
qiujian16
qiujian16 reviewed Nov 17, 2025
View reviewed changes
Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I'd like to have two examples on how mwrs status looks like during rollback:

  1. upgrade and abort, how will the status changes (conditions/reasons/summary etc) among each state. And how user can know whether a rollback is done in which revision?
  2. manual rollback, how user set rollback and check if rollback is finished.

@annelaucg annelaucg mentioned this pull request Nov 19, 2025
Closed
@youngbupark youngbupark mentioned this pull request Nov 21, 2025
Merged
qiujian16
qiujian16 reviewed Dec 1, 2025
View reviewed changes
@qiujian16
Copy link
Member

qiujian16 commented Dec 2, 2025

I do not see any outstanding issue, I think it is fine to be merged with this #164 (comment) updated.

/approve

leave to @haoqing0110 for final tag.

@openshift-ci openshift-ci bot added the approved label Dec 2, 2025
@youngbupark youngbupark force-pushed the add-rollback branch 3 times, most recently from 947ba04 to bffc10a Compare December 2, 2025 03:41
@qiujian16
Copy link
Member

qiujian16 commented Dec 3, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 3, 2025
@openshift-ci
Copy link

openshift-ci bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, youngbupark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2ece292 into open-cluster-management-io:main Dec 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiujian16 qiujian16 qiujian16 left review comments

@deads2k deads2k Awaiting requested review from deads2k

+2 more reviewers

@haoqing0110 haoqing0110 haoqing0110 left review comments

@annelaucg annelaucg annelaucg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@qiujian16 qiujian16

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@youngbupark @qiujian16 @haoqing0110 @annelaucg