Merge pull request #18752 from danidoni/remove-jshint-unused-comments

Replace jshint ignore lines with propper function exports

Author: danidoni

src/api/app/assets/javascripts/webui/autocomplete.js

@@ -1,4 +1,6 @@
-function setupAutocomplete(selector) { // jshint ignore:line
+/* exported setupAutocomplete */
+
+function setupAutocomplete(selector) {
   $(selector).autocomplete({
     // Note: 'append' is optional and only needed when there is no element with class ui-front
     appendTo:  $(selector).data('append'),

src/api/app/assets/javascripts/webui/badge.js

@@ -1,11 +1,14 @@
+/* exported badgeTextCopy */
+/* global BASE_BADGE_URL, BASE_PACKAGE_URL */
+
 // BASE_BADGE_URL and BASE_PACKAGE_URL are set in the view
 function buildBadge() {
-  var badgeImageUrl = new URL(BASE_BADGE_URL); // jshint ignore:line
+  var badgeImageUrl = new URL(BASE_BADGE_URL);
   badgeImageUrl.searchParams.set('type', $('#badge-style-selector').val());
   $('#badge-preview').attr("src", badgeImageUrl);
-  return '[![build result](' + badgeImageUrl + ')](' + BASE_PACKAGE_URL + ')'; // jshint ignore:line
+  return '[![build result](' + badgeImageUrl + ')](' + BASE_PACKAGE_URL + ')';
 }
 
-function badgeTextCopy() { // jshint ignore:line
+function badgeTextCopy() {
   $('#copy-to-clipboard-readonly').val(buildBadge());
 }

src/api/app/assets/javascripts/webui/banners.js

@@ -1,4 +1,6 @@
-function dismissBanner(bannerId, cookieId) { // jshint ignore:line
+/* exported dismissBanner */
+
+function dismissBanner(bannerId, cookieId) {
   const btn = document.getElementById(bannerId);
   if (btn) {
     btn.addEventListener("click", function () {

src/api/app/assets/javascripts/webui/buildresult.js

@@ -1,8 +1,11 @@
+/* exported updateRpmlintResult, updateBuildResult, updateArchDisplay, toggleBuildInfo */
+/* global initializePopovers */
+
 // TODO: replace with the content of
 // app/assets/javascripts/webui/request_show_redesign/build_results.js
 // after the rollout of 'request_show_redesign'.
 
-function updateRpmlintResult(index) { // jshint ignore:line
+function updateRpmlintResult(index) {
   $('#rpm'+index+'-reload').addClass('fa-spin');
   $.ajax({
     url: '/package/rpmlint_result',
@@ -19,7 +22,7 @@ function updateRpmlintResult(index) { // jshint ignore:line
   });
 }
 
-function updateBuildResult(index) { // jshint ignore:line
+function updateBuildResult(index) {
   var collapsedPackages = [];
   var collapsedRepositories = {};
   $('.result div.collapse:not(.show)').map(function(_index, domElement) {
@@ -49,12 +52,12 @@ function updateBuildResult(index) { // jshint ignore:line
     },
     complete: function() {
       $('#build' + index + '-reload').removeClass('fa-spin');
-      initializePopovers('[data-toggle="popover"]'); // jshint ignore:line
+      initializePopovers('[data-toggle="popover"]');
     }
   });
 }
 
-function updateArchDisplay(index) { // jshint ignore:line
+function updateArchDisplay(index) {
   $('.rpmlint_arch_select_' + index).hide();
   $('select[name="rpmlint_arch_select_' + index + '_' + $('#rpmlint_repo_select_' + index + ' option:selected').attr('value') + '"]').show();
   updateRpmlintDisplay(index);
@@ -75,7 +78,7 @@ function updateRpmlintDisplay(index) {
 }
 
 // TODO: Stop using toggleBuildInfo in favor of the generic toggleCollapsibleTooltip
-function toggleBuildInfo() { // jshint ignore:line
+function toggleBuildInfo() {
   $('.toggle-build-info').on('click', function(){
     var replaceTitle = $(this).attr('title') === 'Click to keep it open' ? 'Click to close it' : 'Click to keep it open';
     var infoContainer = $(this).parents('.toggle-build-info-parent').next();

src/api/app/assets/javascripts/webui/canned_responses.js

@@ -1,4 +1,6 @@
-function setupCannedResponses() { // jshint ignore:line
+/* exported setupCannedResponses */
+
+function setupCannedResponses() {
   $('[data-canned-controller]').on('click', '[data-canned-response]', function(e) {
     $(e.target).closest('[data-canned-controller]').find('textarea').val(e.target.dataset.cannedResponse);
     // let's make sure this exists first, to avoid errors

src/api/app/assets/javascripts/webui/collapsible_text.js

@@ -1,4 +1,6 @@
-function setCollapsible() { // jshint ignore:line
+/* exported setCollapsible */
+
+function setCollapsible() {
   $('.obs-collapsible-textbox').each(function() {
     var container = $(this);
     var textBox = container.find('.obs-collapsible-text');

src/api/app/assets/javascripts/webui/collapsible_tooltip.js

@@ -1,4 +1,6 @@
-function toggleCollapsibleTooltip() { // jshint ignore:line
+/* exported toggleCollapsibleTooltip */
+
+function toggleCollapsibleTooltip() {
   $('.collapsible-tooltip').on('click', function(){
     var replaceTitle = $(this).attr('title') === 'Click to keep it open' ? 'Click to close it' : 'Click to keep it open';
     var infoContainer = $(this).parents('.collapsible-tooltip-parent').next();

src/api/app/assets/javascripts/webui/comment.js

@@ -1,4 +1,4 @@
-function resizeTextarea(textarea) { // jshint ignore:line
+function resizeTextarea(textarea) {
   var heightPerRow = Math.ceil(textarea.clientHeight / textarea.rows);
   var linesOfText = Math.ceil(textarea.scrollHeight / heightPerRow);
   var rowsToIncrease = linesOfText - textarea.rows;

src/api/app/assets/javascripts/webui/datatables.js

@@ -1,3 +1,5 @@
+/* exported initializeDataTable, initializeRemoteDatatable */
+
 //= require datatables/jquery.dataTables
 //= require datatables/dataTables.bootstrap5
 //= require datatables/extensions/Responsive/dataTables.responsive
@@ -27,12 +29,12 @@ var DEFAULT_DT_PARAMS = {
   }
 };
 
-function initializeDataTable(cssSelector, params){ // jshint ignore:line
+function initializeDataTable(cssSelector, params){
   var newParams = $.extend({}, DEFAULT_DT_PARAMS, params);
   $(cssSelector).DataTable(newParams);
 }
 
-function initializeRemoteDatatable(cssSelector, params) { // jshint ignore:line
+function initializeRemoteDatatable(cssSelector, params) {
   var defaultRemoteParams = {
     processing: true,
     serverSide: true,

src/api/app/assets/javascripts/webui/delete_confirmation_dialog.js

@@ -1,4 +1,6 @@
-function collectDeleteConfirmationModalsAndSetValues() { // jshint ignore:line
+/* exported collectDeleteConfirmationModalsAndSetValues */
+
+function collectDeleteConfirmationModalsAndSetValues() {
   $.each(modalIds(), function( _index, modalId ) {
     setValuesOnDeleteConfirmationDialog(modalId);
   });