diff --git a/.changeset/fiery-sloths-shout.md b/.changeset/fiery-sloths-shout.md new file mode 100644 index 000000000..88523c70f --- /dev/null +++ b/.changeset/fiery-sloths-shout.md @@ -0,0 +1,5 @@ +--- +'@openchoreo/backstage-plugin-openchoreo-observability': patch +--- + +Remove the End Time column from the traces table and widen the Trace Name column. diff --git a/plugins/openchoreo-observability/src/components/Traces/TracesTable.test.tsx b/plugins/openchoreo-observability/src/components/Traces/TracesTable.test.tsx index 4447ea5f2..978fc6def 100644 --- a/plugins/openchoreo-observability/src/components/Traces/TracesTable.test.tsx +++ b/plugins/openchoreo-observability/src/components/Traces/TracesTable.test.tsx @@ -78,7 +78,6 @@ describe('TracesTable', () => { expect(screen.getByText('Trace Name')).toBeInTheDocument(); expect(screen.getByText('Start Time')).toBeInTheDocument(); - expect(screen.getByText('End Time')).toBeInTheDocument(); expect(screen.getByText('Duration')).toBeInTheDocument(); expect(screen.getByText('Number of Spans')).toBeInTheDocument(); expect(screen.getByText('Details')).toBeInTheDocument(); @@ -157,4 +156,12 @@ describe('TracesTable', () => { expect(container.querySelector('[class*="errorStripe"]')).toBeNull(); }); + + // Start time and duration provide enough timing information without cluttering the table. + it('does not display end time in the traces table', () => { + renderTable(); + + expect(screen.queryByText('End Time')).not.toBeInTheDocument(); + expect(screen.queryByText(sampleTrace.endTime)).not.toBeInTheDocument(); + }); }); diff --git a/plugins/openchoreo-observability/src/components/Traces/TracesTable.tsx b/plugins/openchoreo-observability/src/components/Traces/TracesTable.tsx index 875576269..de2c3e6db 100644 --- a/plugins/openchoreo-observability/src/components/Traces/TracesTable.tsx +++ b/plugins/openchoreo-observability/src/components/Traces/TracesTable.tsx @@ -50,7 +50,6 @@ const HEADER_COLUMNS: { }[] = [ { key: 'traceName', label: 'Trace Name' }, { key: 'startTime', label: 'Start Time' }, - { key: 'endTime', label: 'End Time' }, { key: 'duration', label: 'Duration' }, { key: 'spanCount', label: 'Number of Spans' }, { key: 'details', label: 'Details', align: 'right' }, @@ -152,12 +151,6 @@ export const TracesTable: FC = ({ > {trace.startTime} - - {trace.endTime} - ({ - traceName: '0 0 12%', + traceName: '0 0 32%', startTime: '0 0 20%', - endTime: '0 0 20%', duration: '0 0 12%', spanCount: '0 0 12%', details: '0 0 12%',