fix(deps): pin to published versions of tsx and claude-agent-acp#343
fix(deps): pin to published versions of tsx and claude-agent-acp#343trumpyla wants to merge 1 commit into
Conversation
acpx 0.9.0 declared two versions that are not (or were not) published to npm, leaving fresh installs broken: - tsx ^4.22.0 -> ^4.21.0 At the time of the 0.9.0 release `npm view tsx` topped out at 4.21.0, so `pnpm i` / `npm i` failed ETARGET. tsx 4.22.x has since been republished, but ^4.21.0 is the safer floor and resolves to the same 4.22.3 on a fresh install. - @agentclientprotocol/claude-agent-acp ^0.36.1 -> ^0.33.1 The built-in agent registry pinned a version that 404s (npm latest is 0.33.1), so `acpx claude` fails to initialize on a clean install. Both pins lowered to the newest versions actually on the registry. Lockfile refreshed.
|
Codex review: needs real behavior proof before merge. Latest ClawSweeper review: 2026-05-23 22:05 UTC / May 23, 2026, 6:05 PM ET. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: no. Current npm registry metadata now publishes both PR rating Rank-up moves:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. Real behavior proof Risk before merge
Maintainer options:
Copy recommended automerge instructionNext step before merge Security Review findings
Review detailsBest possible solution: Keep the Claude adapter on a currently published non-downgrade range and only adjust dependency floors when current registry evidence and install proof show that a lower floor is still needed. Do we have a high-confidence way to reproduce the issue? No. Current npm registry metadata now publishes both Is this the best way to solve the issue? No. The Claude adapter downgrade is no longer the narrowest safe fix; the safer solution is to keep a published non-downgrade range and require fresh install plus launch proof for any dependency-floor change. Label changes:
Label justifications:
Full review comments:
Overall correctness: patch is incorrect Acceptance criteria:
What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against aa61f9e8ba07. |
|
ClawSweeper PR egg 🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat. Where did the egg go?
|
Summary
acpx@0.9.0declared two dependency versions that are not (or were not) published to npm, leaving fresh installs broken:tsx^4.22.04.21.0(at the time of 0.9.0's release)pnpm i/npm ifails withETARGET No matching version@agentclientprotocol/claude-agent-acp^0.36.1(insrc/agent-registry.ts)0.33.1acpx claudecannot spawn the adapter —npx -y …@0.36.1404sBoth pins lowered to the newest versions actually on the registry.
Changes
package.json—tsx:^4.22.0→^4.21.0src/agent-registry.ts—claude:^0.36.1→^0.33.1pnpm-lock.yaml— refreshed to matchtsx 4.22.xhas since been republished (4.22.3), but^4.21.0is a safer floor and resolves to the same4.22.3on a fresh install, so keeping it as the minimum protects against another transient republish.Verification
pnpm installthenpnpm run buildsucceed on a clean clone.npm install -g .produces a working globalacpx(acpx --version→ 0.9.0).dist/no longer carries the broken@0.36.1reference (grep returns nothing);acpx claudespawnsclaude-agent-acp@0.33.1cleanly.