feature: Delayed background rendering #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
force-pushed
the
delayed-background-rendering
branch
from
fd57b92 to
98dad6b
Compare
andiwand
force-pushed
the
delayed-background-rendering
branch
from
98dad6b to
f7aee77
Compare
andiwand
force-pushed
the
delayed-background-rendering
branch
from
f7aee77 to
1dad166
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is only possible to process the whole PDF at once which can take a significant amount of time for big files. One of the biggest time consumers is rendering of the background images, which is practically just rendering a single page. This (should) be independent from generating the HTML and from rendering other pages.
In this PR I introduce a new config param
delay_backgroundwhich generates the HTML for the background images as if they have been rendered already but then lets the user call a newHTMLRenderer::renderPagefunction themselves for the actual rendering and storing of the image.This required to change
SplashBackgroundRenderera bit as it assumed the background image might not be the full page. I did not see a good reason for this (? potential problems might be discovered later) and changed it so it always expects a fully rendered background image. This also conflicts with the fallback renderer as we only know that the normal renderer failed after we tried. But I believe the fallback is only a workaround which we should not rely on in the best case anyways.