fix: use ASPECTS_RAW_XAPI_TABLE as source for xapi events

[Ian2012]

This PR make use of the ASPECTS_RAW_XAPI_TABLE variable instead of ASPECTS_VECTOR_RAW_XAPI_TABLE for consistency with the tutor plugins for Aspects. Those variables are effectively the same so it shouldn't affect most of the installations unless the ASPECTS_VECTOR_RAW_XAPI_TABLE was changed from the default.

The breaking changed is detailed on the docs

[openedx-webhooks]

Thanks for the pull request, @Ian2012!

This repository is currently maintained by @bmtcril.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[saraburns1]

@Ian2012 do you need to change this in the alembic migrations too?

[Ian2012]

No, only here. There will be only one setting for that table

[Ian2012]

@bmtcril do we need a version bump?

[bmtcril]

I'm not 100% sure I understand what the downstream effects of this will be. I think it's this?

These are all fine:

• New install - everything goes to xapi_events_all
• Normal upgrade on instance using Vector with default settings - everything goes to xapi_events_all

Unrelated to this change, but still breaking:

• Normal upgrade on instance that has been using Celery / Ralph with default settings - database will change from xapi to openedx but table name is still xapi_events_all, admins can change the ASPECTS_VECTOR_DATABASE to xapi or migrate data

Actual possible breaking change from this PR:

• Update if someone has customized ASPECTS_VECTOR_RAW_XAPI_TABLE - they will need to change their customization to use ASPECTS_RAW_XAPI_TABLE instead or will need to migrate data

Does that sound right?

[Ian2012]

Yes, it's correct

[bmtcril]

Ok, then yes this is a major version bump and we need to document the breaking case probably here, in the README, and again in openedx-aspects upgrade doc, and likely in the README of tutor-contrib-aspects too.

[Ian2012]

I've added docs for this

[bmtcril]

Maybe:

As if version 7.0.0 this project uses ASPECTS_RAW_XAPI_TABLE as the source for xAPI events for both Ralph and Vector pipelines. If you have previously customized ASPECTS_VECTOR_RAW_XAPI_TABLE in your configuration, you will need to update it to use ASPECTS_RAW_XAPI_TABLE instead.

[bmtcril]

I think this is good to go if you can just update the PR description to make it easier to find this change later 👍

[Ian2012]

Ok, updated