Skip to content

Commit 15ebbca

Browse files
committed
fix: address feedback, log request URL instead
1 parent 877c41e commit 15ebbca

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

lms/djangoapps/lti_provider/users.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,32 +60,32 @@ def authenticate_lti_user(request, lti_user_id, lti_consumer):
6060
log.info(
6161
'LTI consumer requires existing user account for LTI user ID: %s from request: %s',
6262
lti_user_id,
63-
request
63+
request.path
6464
)
6565
if request.user.is_authenticated and request.user.email.lower() == profile["email"]:
6666
lti_user = create_lti_user(lti_user_id, lti_consumer, profile)
6767
else:
6868
log.error(
69-
'LTI user account linking failed for LTI user ID: %s from request: %s: '
69+
'LTI user account linking failed for LTI user ID: %s for request: %s: '
7070
'either user is not logged in or email mismatched',
7171
lti_user_id,
72-
request
72+
request.path
7373
)
7474
# Ask the user to login before linking.
7575
raise PermissionDenied() from exc
7676
elif lti_consumer.use_lti_pii:
7777
log.info(
7878
'Creating LTI user with PII for LTI user ID: %s from request: %s',
7979
lti_user_id,
80-
request
80+
request.path
8181
)
8282
profile["username"] = lti_user_id
8383
lti_user = create_lti_user(lti_user_id, lti_consumer, profile)
8484
else:
8585
log.info(
8686
'Creating LTI user without PII for LTI user ID: %s from request: %s',
8787
lti_user_id,
88-
request
88+
request.path
8989
)
9090
lti_user = create_lti_user(lti_user_id, lti_consumer)
9191

@@ -96,7 +96,7 @@ def authenticate_lti_user(request, lti_user_id, lti_consumer):
9696
log.info(
9797
'Switching logged-in user to LTI user ID: %s for request: %s',
9898
lti_user_id,
99-
request
99+
request.path
100100
)
101101
switch_user(request, lti_user, lti_consumer)
102102

@@ -161,7 +161,7 @@ def switch_user(request, lti_user, lti_consumer):
161161
if not edx_user:
162162
# This shouldn't happen, since we've created edX accounts for any LTI
163163
# users by this point, but just in case we can return a 403.
164-
log.error('Switching user failed for LTI user ID: %s from request: %s', lti_user.lti_user_id, request)
164+
log.error('Switching user failed for LTI user ID: %s from request: %s', lti_user.lti_user_id, request.path)
165165
raise PermissionDenied()
166166
login(request, edx_user)
167167
mark_user_change_as_expected(edx_user.id)

lms/djangoapps/lti_provider/views.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def lti_launch(request, course_id, usage_id):
6363
# missing
6464
params = get_required_parameters(request.POST)
6565
if not params:
66-
log.info('Missing required LTI parameters in LTI request: %s', request)
66+
log.info('Missing required LTI parameters in LTI request: %s', request.path)
6767
return HttpResponseBadRequest()
6868
params.update(get_optional_parameters(request.POST))
6969
params.update(get_custom_parameters(request.POST))
@@ -81,15 +81,15 @@ def lti_launch(request, course_id, usage_id):
8181
'consumer key: %s and instance GUID: %s for request: %s',
8282
params['oauth_consumer_key'],
8383
params.get('tool_consumer_instance_guid', None),
84-
request
84+
request.path
8585
)
8686
return HttpResponseForbidden()
8787

8888
# Check the OAuth signature on the message
8989
if not SignatureValidator(lti_consumer).verify(request):
9090
log.error(
9191
'Invalid OAuth signature for LTI launch from request: %s',
92-
request
92+
request.path
9393
)
9494
return HttpResponseForbidden()
9595

@@ -101,7 +101,7 @@ def lti_launch(request, course_id, usage_id):
101101
'Invalid course key %s or usage key %s from request %s',
102102
course_id,
103103
usage_id,
104-
request
104+
request.path
105105
)
106106
raise Http404() # lint-amnesty, pylint: disable=raise-missing-from
107107
params['course_key'] = course_key
@@ -116,7 +116,7 @@ def lti_launch(request, course_id, usage_id):
116116
log.info(
117117
'LTI user authentication failed for user Id: %s from request: %s',
118118
user_id,
119-
request
119+
request.path
120120
)
121121
request.session.flush()
122122
context = {

0 commit comments

Comments
 (0)