fix: removal of temporary saml toggle

Author: ktyagiapphelix2u

common/djangoapps/third_party_auth/management/commands/tests/test_saml.py

@@ -64,21 +64,13 @@ def setUp(self):
         self.site = Site.objects.get_current()
         self.other_site = Site.objects.create(domain='other.example.com', name='Other Site')
 
-        # Create a disabled SAML configuration that won't be processed
-        # This uses a different site to avoid signal handler interference with test providers
-        self.disabled_site = Site.objects.create(domain='disabled.fake', name='disabled.fake')
+        # We are creating SAMLConfiguration instance here so that there is always at-least one
+        # disabled saml configuration instance, this is done to verify that disabled configurations are
+        # not processed.
         self.saml_config = SAMLConfigurationFactory.create(
             enabled=False,
-            site=self.disabled_site
-        )
-
-        # Create initial provider config with saml_configuration set to avoid orphaned provider
-        # Using a site/slug combination that won't match the test configurations created later
-        provider_saml_config = SAMLConfigurationFactory.create(
-            enabled=True,
             site__domain='testserver.fake',
-            site__name='testserver.fake',
-            slug='test-shib'
+            site__name='testserver.fake'
         )
         self.provider_config = SAMLProviderConfigFactory.create(
             site__domain='testserver.fake',
@@ -87,9 +79,10 @@ def setUp(self):
             name='TestShib College',
             entity_id='https://idp.testshib.org/idp/shibboleth',
             metadata_source='https://www.testshib.org/metadata/testshib-providers.xml',
-            saml_configuration=provider_saml_config
         )
 
+
+
     def _setup_test_configs_for_run_checks(self):
         """
         Helper method to create SAML configurations for run-checks tests.