fix: fixed tests and quality failures

Author: Sameen Fatima

openedx/core/djangoapps/user_api/accounts/tests/test_retirement_views.py

@@ -22,11 +22,6 @@
     EnterpriseCustomerUser,
     PendingEnterpriseCustomerUser
 )
-# This is a temporary import path while we transition from integrated_channels to channel_integrations
-if getattr(settings, 'ENABLE_LEGACY_INTEGRATED_CHANNELS', True):
-    from integrated_channels.sap_success_factors.models import SapSuccessFactorsLearnerDataTransmissionAudit
-else:
-    from channel_integrations.sap_success_factors.models import SapSuccessFactorsLearnerDataTransmissionAudit
 from opaque_keys.edx.keys import CourseKey
 from rest_framework import status
 from social_django.models import UserSocialAuth
@@ -92,6 +87,12 @@
     setup_retirement_states
 )
 
+# This is a temporary import path while we transition from integrated_channels to channel_integrations
+if getattr(settings, 'ENABLE_LEGACY_INTEGRATED_CHANNELS', True):
+    from integrated_channels.sap_success_factors.models import SapSuccessFactorsLearnerDataTransmissionAudit
+else:
+    from channel_integrations.sap_success_factors.models import SapSuccessFactorsLearnerDataTransmissionAudit
+
 
 def build_jwt_headers(user):
     """

openedx/core/djangoapps/user_api/accounts/views.py

@@ -26,13 +26,6 @@
 from edx_rest_framework_extensions.auth.jwt.authentication import JwtAuthentication
 from edx_rest_framework_extensions.auth.session.authentication import SessionAuthenticationAllowInactiveUser
 from enterprise.models import EnterpriseCourseEnrollment, EnterpriseCustomerUser, PendingEnterpriseCustomerUser
-# This is a temporary import path while we transition from integrated_channels to channel_integrations
-if getattr(settings, 'ENABLE_LEGACY_INTEGRATED_CHANNELS', True):
-    from integrated_channels.degreed.models import DegreedLearnerDataTransmissionAudit
-    from integrated_channels.sap_success_factors.models import SapSuccessFactorsLearnerDataTransmissionAudit
-else:
-    from channel_integrations.degreed2.models import Degreed2LearnerDataTransmissionAudit as DegreedLearnerDataTransmissionAudit
-    from channel_integrations.sap_success_factors.models import SapSuccessFactorsLearnerDataTransmissionAudit
 from rest_framework import permissions, status
 from rest_framework.authentication import SessionAuthentication
 from rest_framework.exceptions import UnsupportedMediaType
@@ -102,6 +95,15 @@
 from .signals import USER_RETIRE_LMS_CRITICAL, USER_RETIRE_LMS_MISC, USER_RETIRE_MAILINGS
 from .utils import create_retirement_request_and_deactivate_account, username_suffix_generator
 
+# This is a temporary import path while we transition from integrated_channels to channel_integrations
+if getattr(settings, 'ENABLE_LEGACY_INTEGRATED_CHANNELS', True):
+    from integrated_channels.degreed.models import DegreedLearnerDataTransmissionAudit
+    from integrated_channels.sap_success_factors.models import SapSuccessFactorsLearnerDataTransmissionAudit
+else:
+    from channel_integrations.degreed2.models import Degreed2LearnerDataTransmissionAudit \
+        as DegreedLearnerDataTransmissionAudit
+    from channel_integrations.sap_success_factors.models import SapSuccessFactorsLearnerDataTransmissionAudit
+
 log = logging.getLogger(__name__)
 
 USER_PROFILE_PII = {

openedx/core/djangoapps/user_api/management/commands/create_user_gdpr_testing.py

@@ -19,11 +19,6 @@
     EnterpriseCustomerUser,
     PendingEnterpriseCustomerUser
 )
-# This is a temporary import path while we transition from integrated_channels to channel_integrations
-if getattr(settings, 'ENABLE_LEGACY_INTEGRATED_CHANNELS', True):
-    from integrated_channels.sap_success_factors.models import SapSuccessFactorsLearnerDataTransmissionAudit
-else:
-    from channel_integrations.sap_success_factors.models import SapSuccessFactorsLearnerDataTransmissionAudit
 from opaque_keys.edx.keys import CourseKey
 from zoneinfo import ZoneInfo
 
@@ -36,6 +31,12 @@
 
 from ...models import UserOrgTag
 
+# This is a temporary import path while we transition from integrated_channels to channel_integrations
+if getattr(settings, 'ENABLE_LEGACY_INTEGRATED_CHANNELS', True):
+    from integrated_channels.sap_success_factors.models import SapSuccessFactorsLearnerDataTransmissionAudit
+else:
+    from channel_integrations.sap_success_factors.models import SapSuccessFactorsLearnerDataTransmissionAudit
+
 
 class Command(BaseCommand):
     """

openedx/features/enterprise_support/signals.py

@@ -10,6 +10,14 @@
 from django.db.models.signals import post_save, pre_save
 from django.dispatch import receiver
 from enterprise.models import EnterpriseCourseEnrollment, EnterpriseCustomer
+from slumber.exceptions import HttpClientError
+
+from common.djangoapps.student.signals import UNENROLL_DONE
+from openedx.core.djangoapps.commerce.utils import ecommerce_api_client
+from openedx.core.djangoapps.signals.signals import COURSE_ASSESSMENT_GRADE_CHANGED, COURSE_GRADE_NOW_PASSED
+from openedx.features.enterprise_support.tasks import clear_enterprise_customer_data_consent_share_cache
+from openedx.features.enterprise_support.utils import clear_data_consent_share_cache, is_enterprise_learner
+
 # This is a temporary import path while we transition from integrated_channels to channel_integrations
 if getattr(settings, 'ENABLE_LEGACY_INTEGRATED_CHANNELS', True):
     from integrated_channels.integrated_channel.tasks import (
@@ -21,13 +29,6 @@
         transmit_single_learner_data,
         transmit_single_subsection_learner_data
     )
-from slumber.exceptions import HttpClientError
-
-from common.djangoapps.student.signals import UNENROLL_DONE
-from openedx.core.djangoapps.commerce.utils import ecommerce_api_client
-from openedx.core.djangoapps.signals.signals import COURSE_ASSESSMENT_GRADE_CHANGED, COURSE_GRADE_NOW_PASSED
-from openedx.features.enterprise_support.tasks import clear_enterprise_customer_data_consent_share_cache
-from openedx.features.enterprise_support.utils import clear_data_consent_share_cache, is_enterprise_learner
 
 log = logging.getLogger(__name__)
 

openedx/features/enterprise_support/tests/test_signals.py

@@ -197,9 +197,9 @@ def test_handle_enterprise_learner_passing_grade(self):
         Test to assert transmit_single_learner_data is called when COURSE_GRADE_NOW_PASSED signal is fired
         """
         with patch(
-            'integrated_channels.integrated_channel.tasks.transmit_single_subsection_learner_data.apply_async' 
+            'integrated_channels.integrated_channel.tasks.transmit_single_learner_data.apply_async'
             if getattr(settings, 'ENABLE_LEGACY_INTEGRATED_CHANNELS', True) else
-            'channel_integrations.integrated_channel.tasks.transmit_single_subsection_learner_data.apply_async',
+            'channel_integrations.integrated_channel.tasks.transmit_single_learner_data.apply_async',
             return_value=None
         ) as mock_task_apply:
             course_key = CourseKey.from_string(self.course_id)
@@ -221,7 +221,7 @@ def test_handle_enterprise_learner_subsection(self):
         Test to assert transmit_subsection_learner_data is called when COURSE_ASSESSMENT_GRADE_CHANGED signal is fired.
         """
         with patch(
-            'integrated_channels.integrated_channel.tasks.transmit_single_subsection_learner_data.apply_async' 
+            'integrated_channels.integrated_channel.tasks.transmit_single_subsection_learner_data.apply_async'
             if getattr(settings, 'ENABLE_LEGACY_INTEGRATED_CHANNELS', True) else
             'channel_integrations.integrated_channel.tasks.transmit_single_subsection_learner_data.apply_async',
             return_value=None