Skip to content

Commit 9254e20

Browse files
fix: move course_app extraction after setting the app status
1 parent 646a71f commit 9254e20

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

cms/djangoapps/contentstore/rest_api/v0/tests/test_advanced_settings.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
from django.test import override_settings
99
from django.urls import reverse
1010
from milestones.tests.utils import MilestonesTestCaseMixin
11+
from rest_framework.exceptions import ValidationError
1112

1213
from cms.djangoapps.contentstore.tests.utils import CourseTestCase
1314

@@ -154,7 +155,7 @@ def test_patch_advanced_setting_with_exception(self, mock_set_course_app_status)
154155
Test that exceptions in set_course_app_status are caught and don't break the flow.
155156
"""
156157
# Mock set_course_app_status to raise an exception
157-
mock_set_course_app_status.side_effect = Exception("Course app error")
158+
mock_set_course_app_status.side_effect = ValidationError("Course app error")
158159

159160
data = {
160161
"show_calculator": {

openedx/core/djangoapps/course_apps/rest_api/v1/views.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,8 @@ def patch(self, request: Request, course_id: str):
192192
if enabled is None:
193193
raise ValidationError({"enabled": "Must provide value for `enabled` field."})
194194

195-
course_app = CourseAppsPluginManager.get_plugin(app_id)
196195
is_enabled = set_course_app_status(course_key=course_key, app_id=app_id, enabled=enabled, request=request)
196+
course_app = CourseAppsPluginManager.get_plugin(app_id)
197197
serializer = CourseAppSerializer(
198198
course_app,
199199
context={

0 commit comments

Comments
 (0)