fix(csr): recompute status sd from next-state fs/xs - #3469
Merged
JeanRochCoulon merged 2 commits intoAug 14, 2026
Merged
JeanRochCoulon merged 2 commits into
JeanRochCoulon merged 2 commits into
Conversation
jf-cc727
force-pushed
the
fix/cv-6-status-sd-next-state
branch
from
August 12, 2026 11:57
4ab4b3f to
901e9a0
Compare
Contributor
|
❌ failed run, report available here. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a stale
sdrecomputation issue in the CSR status path.It recomputes
mstatus.sdfrommstatus_d.{xs,fs}andvsstatus.sdfromvsstatus_d.{xs,fs}, instead of using the old registered_qstate. This keepssdconsistent with same-cycle updates that already makefsorxsdirty.Related issue: #3460
Why this change is needed:
sdis a summary bit derived from the dirty state offs/xs. In the current implementation,fscan already be updated toDirtyin the next-state logic, whilesdis still recomputed from the previous registered state. This creates a one-cycle inconsistency where the visiblefsstate has advanced butsdstill reflects the old value.Validation:
tohost = 0)Current limitation:
This is a narrow consistency fix for
sdrecomputation and does not otherwise change CSR status semantics.