origin-local-checkout doesn't work with branches

[brenton]

Neither of these commands result in the pre-flight-checks branch being checked out:

vagrant origin-local-checkout --repo openshift-ansible --user rhcarvalho --branch pre-flight-checks
vagrant origin-local-checkout --replace --repo openshift-ansible --user rhcarvalho --branch pre-flight-checks

[stevekuznetsov]

@smarterclayton @danmcp I thought we had fixed that?

[brenton]

fyi, that commit I added is just a hack workaround to explain the problem I'm seeing a little more. I'm not aware of how this problem may have come up or have been solved in the past.

[brenton]

I suspect this behavior may have broken whenever the support for having an 'upstream' remote was added. git checkout <branch> is only equivalent to git checkout -b branch origin/<branch> if there is one remote. When I run vagrant origin-local-checkout --repo openshift-ansible --user rhcarvalho --branch pre-flight-checks I have a locally cloned repo with two remotes origin and upstream.