Feat/manage script testing (#906)

* feat(core): support configurable proof format for anoncreds

Signed-off-by: Yuki I <[email protected]>

* feat(devops): add './manage test' command for isolated testing

Signed-off-by: Yuki I <[email protected]>

* style: apply black code formatting

Signed-off-by: Yuki I <[email protected]>

* test(core): isolate tests to prevent pollution and improve logging

Signed-off-by: Yuki I <[email protected]>

* refactor(core): add config validation and improve proof format fallback

Signed-off-by: Yuki I <[email protected]>

* test(core): add missing coverage for anoncreds fallback

Signed-off-by: Yuki I <[email protected]>

* fix(build): align proof format config with project standards

Signed-off-by: Yuki I <[email protected]>

* style(core): apply black code formatting

Signed-off-by: Yuki I <[email protected]>

---------

Signed-off-by: Yuki I <[email protected]>
Co-authored-by: Yuki I <[email protected]>

Author: MonolithicMonk

docker/manage

@@ -88,6 +88,18 @@ usage() {
 
               $0 scale 5
 
+      test -  Builds a test-specific Docker image and runs the test suite
+              inside the container. You can pass pytest arguments.
+
+              $0 test
+              $0 test -v
+              $0 test oidc-controller/api/core/tests/
+
+      format - Runs 'black' code formatter on the source code.
+               Automatically fixes formatting issues.
+
+               $0 format
+
       logs - Display the logs from the docker compose run (ctrl-c to exit).
 
       stop - Stops the services.  This is a non-destructive process.  The volumes and containers
@@ -129,7 +141,7 @@ configureEnvironment() {
   if [ -f .env ]; then
     while read line; do
       if [[ ! "$line" =~ ^\# ]] && [[ "$line" =~ .*= ]]; then
-        export ${line//[$'\r\n']}
+        export "${line//[$'\r\n']}"
       fi
     done <.env
   fi
@@ -456,6 +468,42 @@ scale)
   echo "Scaling controller to ${REPLICAS} replicas..."
   docker-compose up -d --force-recreate controller
   ;;
+test)
+  # 1. Build the test image
+  # We use the same context ('..') as the production build so we can see pyproject.toml
+  echoInfo "Building test environment image..."
+  docker build \
+    -t 'acapy-vc-authn-oidc-tests' \
+    -f './oidc-controller/Dockerfile.test' '..'
+
+  # 2. Run the container
+  # We pass $@ (all remaining arguments) to the entrypoint (pytest)
+  # This allows running specific tests: ./manage test -v -k "test_config"
+  echoInfo "Running tests in isolated container..."
+  docker run --rm 'acapy-vc-authn-oidc-tests' "$@"
+  ;;
+format)
+  # 1. Ensure image exists (re-use the test build logic)
+  echoInfo "Building tool environment image..."
+  docker build \
+    -t 'acapy-vc-authn-oidc-tests' \
+    -f './oidc-controller/Dockerfile.test' '..'
+
+  # 2. Run black
+  # We calculate the absolute path to oidc-controller relative to the script location
+  # to ensure the mount works regardless of where you run ./manage from
+  PROJECT_ROOT=$(cd "${SCRIPT_HOME}/../" && pwd)
+  
+  echoInfo "Formatting code with Black..."
+  docker run --rm \
+    --user $(id -u):$(id -g) \
+    -v "${PROJECT_ROOT}/oidc-controller":/app/src/oidc-controller \
+    --entrypoint black \
+    'acapy-vc-authn-oidc-tests' \
+    /app/src/oidc-controller
+
+  echoSuccess "Formatting complete."
+  ;;
 single-pod)
   if [[ ! -f ".env" ]]; then
     # first/clean run, prompt user selections

docker/oidc-controller/Dockerfile.test

@@ -0,0 +1,23 @@
+FROM python:3.12
+
+WORKDIR /app/src
+
+# Install Poetry
+ENV POETRY_VIRTUALENVS_CREATE=false
+RUN pip3 install --no-cache-dir poetry==2.0
+
+# Copy configuration files from the project root (context is ..)
+COPY pyproject.toml poetry.lock README.md ./
+
+# Install ALL dependencies including dev (pytest, tox, mock, etc)
+# --no-root prevents installing the project itself as a package yet
+RUN poetry install --no-root --with dev
+
+# Copy the source code
+COPY ./oidc-controller ./oidc-controller
+
+# Set the python path so imports work correctly
+ENV PYTHONPATH=/app/src/oidc-controller
+
+# Default command is to run pytest
+ENTRYPOINT ["pytest"]

oidc-controller/api/core/oidc/tests/test_issue_token_service.py

@@ -451,3 +451,23 @@ async def test_get_claims_fallback_migration_logic(auth_session_fixture):
     # Assert: Should still find the data under 'indy' key
     attributes = json.loads(claims["vc_presented_attributes"])
     assert attributes["email"] == "[email protected]"
+
+
+@pytest.mark.asyncio
+async def test_get_claims_fallback_reverse_migration_logic(auth_session_fixture):
+    """
+    Verify fallback when config is 'indy' but data is 'anoncreds'.
+    This covers the 'elif "anoncreds" in pres_request' branch.
+    """
+    # Arrange: Data has 'anoncreds' key
+    auth_session_fixture.presentation_exchange = create_mock_presentation_exchange(
+        "anoncreds"
+    )
+
+    # Act: Config is set to 'indy' (simulating default/legacy config)
+    with patch.object(settings, "ACAPY_PROOF_FORMAT", "indy"):
+        claims = Token.get_claims(auth_session_fixture, ver_config)
+
+    # Assert: Should correctly find the data under 'anoncreds' key
+    attributes = json.loads(claims["vc_presented_attributes"])
+    assert attributes["email"] == "[email protected]"