🎨 Improve type handling in revocation routes

Signed-off-by: ff137 <[email protected]>

Author: ff137

acapy_agent/anoncreds/routes/revocation/lists/routes.py

@@ -27,7 +27,7 @@ async def rev_list_post(request: web.BaseRequest):
     """Request handler for creating registering a revocation list."""
     _, profile, body, options = await get_request_body_with_profile_check(request)
 
-    rev_reg_def_id = body.get("rev_reg_def_id")
+    rev_reg_def_id = body["rev_reg_def_id"]  # required in request schema
 
     revocation = AnonCredsRevocation(profile)
     result = await shield(

acapy_agent/anoncreds/routes/revocation/registry/routes.py

@@ -204,7 +204,7 @@ async def get_rev_reg(request: web.BaseRequest):
 
 
 async def _get_issuer_rev_reg_record(
-    profile: AskarAnonCredsProfile, rev_reg_id: str | None
+    profile: AskarAnonCredsProfile, rev_reg_id: str
 ) -> IssuerRevRegRecord:
     # fetch rev reg def from anoncreds
     try:
@@ -548,8 +548,8 @@ async def set_rev_reg_state(request: web.BaseRequest):
 
     is_not_anoncreds_profile_raise_web_exception(profile)
 
-    rev_reg_id = request.match_info["rev_reg_id"]
-    state = request.query.get("state")
+    rev_reg_id: str = request.match_info["rev_reg_id"]
+    state: str = request.query["state"]  # required in query string schema
 
     try:
         revocation = AnonCredsRevocation(profile)

acapy_agent/anoncreds/routes/revocation/tails/routes.py

@@ -41,6 +41,8 @@ async def get_tails_file(request: web.BaseRequest) -> web.FileResponse:
 
     # Get the rev_reg_def again since we need it for the tails_location
     rev_reg_def = await revocation.get_created_revocation_registry_definition(rev_reg_id)
+    if rev_reg_def is None:
+        raise web.HTTPNotFound(reason=f"Rev reg def with id {rev_reg_id} not found")
 
     tails_local_path = rev_reg_def.value.tails_location
     return web.FileResponse(path=tails_local_path, status=200)