Skip to content

[question] Why is the default notification type removed by ConfigConfig.ready() ? #1337

@asmodehn

Description

@asmodehn

I am talking about this code : https://github.com/openwisp/openwisp-controller/blob/master/openwisp_controller/config/apps.py#L245
What is the point of removing the existing default notification type ?

One problematic side effect (in my case at least) is that many tests in the notifications module rely on that notification type.

Therefore I cannot run the notifications tests with the openwisp_controller.config in INSTALLED_APPS.
Which means I cannot be sure if it still works as it should, once it is deployed with the controller module.

Maybe I am holding this the wrong way and there is another (automated) way to make sure the notification code behaves as expected, no matter which other apps are installed ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions