diff --git a/.github/actions/bot-autoassign/stale_pr_bot.py b/.github/actions/bot-autoassign/stale_pr_bot.py index 98e3ee1a..9404909c 100644 --- a/.github/actions/bot-autoassign/stale_pr_bot.py +++ b/.github/actions/bot-autoassign/stale_pr_bot.py @@ -209,6 +209,12 @@ def unassign_linked_issues(self, pr): return 0 def close_stale_pr(self, pr, days_inactive): + # TEMPORARY: auto-close disabled. The stale-detection heuristic + # has been closing PRs that are merely blocked by bot reviews + # (or by reviews the same reviewer later approved). The proper + # fix lives in PR #668; until it lands, no PR is auto-closed. + print(f"Auto-close currently disabled, skipping PR #{pr.number}") + return False if pr.state == "closed": print(f"PR #{pr.number} is already closed, skipping") return True diff --git a/.github/actions/bot-autoassign/tests/test_stale_pr_bot.py b/.github/actions/bot-autoassign/tests/test_stale_pr_bot.py index 32c5ffbb..78307452 100644 --- a/.github/actions/bot-autoassign/tests/test_stale_pr_bot.py +++ b/.github/actions/bot-autoassign/tests/test_stale_pr_bot.py @@ -329,6 +329,7 @@ def test_success(self, bot_env): mock_issue.remove_from_assignees.assert_called_once_with("testuser") +@pytest.mark.skip(reason="Auto-close temporarily disabled; see close_stale_pr stub.") class TestCloseStalePR: def test_success(self, bot_env): bot = StalePRBot()