cloudapi,weldr: enable librepo by default (and update tests)

[mvo5]

We could start by only enabling on weldr, it seems
the service very rarely deals with issue about
out-of-sync mirrors.

---

mocks: make BaseDepsolveResult() return a DepsolveResult

The BaseDepsolveResult was only returning the packages part of
the DepsolveResult. With librepo we need the repos as well so
that packages can be linked to repos. This commit returns the
full DepsolveResult with the Packages/Repos linked now.

---

weldr: enable librepo by default (and update tests)

This commit enables librepo by default in the weldr api. This
should help with on-prem out of sync mirror issues like:
#4427

---

cloudapi: enable librepo by default (and update tests)

This commit enables librepo by default in the cloudapi.

We have librepo in osbuild/images/ibcli/bib for a while now, c.f.
osbuild/image-builder-cli#51
osbuild/bootc-image-builder#786 (enable)
osbuild/bootc-image-builder#840 (make default)

It is not configurable right now, I am not sure there is a reason
to keep libcurl around for manifest generation as its more fragile
but if it is desired I can look into that too. Having it configurable
would allow us to revert to the previous org.osbuild.curl in case
anything is wrong with the new downloader (and arguably it was
only excercised by a relatively small number of people compared
to how much the service is building).

[thozza]

This commit enables librepo by default in the cloudapi. This should help with on-prem out of sync mirror issues like: #4427

AFAIK, it won't, because CloudAPI is not used on-prem by default. Weldr API needs to use it to help with on-prem issues.

[mvo5]

This commit enables librepo by default in the cloudapi. This should help with on-prem out of sync mirror issues like: #4427

AFAIK, it won't, because CloudAPI is not used on-prem by default. Weldr API needs to use it to help with on-prem issues.

You are right of course, silly me! I added support for librepo into weldr too, I leave it as a single PR but we could split and/or start with weldr only etc.

[thozza]

LGTM, thanks

[mvo5]

The tests are currently failing with a variant of

Nov 04 13:47:12 ip-10-31-19-241.us-east-1.aws.redhat.com osbuild-worker[6777]: osbuild.host.RemoteError: RuntimeError: Packages/crontabs-1.11^20190603git9e74f2d-6.el10.noarch.rpm: No more mirrors to try - All mirrors were already tried without success,Packages/passt-0^20250512.g8ec1341-2.el10.x86_64.rpm: No more mirrors to try - All mirrors were already tried without success,Packages/passt-selinux-0^20250512.g8ec1341-2.el10.noarch.rpm: No more mirrors to try - All mirrors were already tried without success

so something is not quite right yet :/

[achilleas-k]

Rebasing on 8f6ecc4.

[achilleas-k]

The tests are currently failing with a variant of

Nov 04 13:47:12 ip-10-31-19-241.us-east-1.aws.redhat.com osbuild-worker[6777]: osbuild.host.RemoteError: RuntimeError: Packages/crontabs-1.11^20190603git9e74f2d-6.el10.noarch.rpm: No more mirrors to try - All mirrors were already tried without success,Packages/passt-0^20250512.g8ec1341-2.el10.x86_64.rpm: No more mirrors to try - All mirrors were already tried without success,Packages/passt-selinux-0^20250512.g8ec1341-2.el10.noarch.rpm: No more mirrors to try - All mirrors were already tried without success

so something is not quite right yet :/

Funny. I'm getting the same on #4904. The manifest is generated with image-builder, so it uses librepo, and then the build fails with the same problem.

[mvo5]

The tests are currently failing with a variant of

Nov 04 13:47:12 ip-10-31-19-241.us-east-1.aws.redhat.com osbuild-worker[6777]: osbuild.host.RemoteError: RuntimeError: Packages/crontabs-1.11^20190603git9e74f2d-6.el10.noarch.rpm: No more mirrors to try - All mirrors were already tried without success,Packages/passt-0^20250512.g8ec1341-2.el10.x86_64.rpm: No more mirrors to try - All mirrors were already tried without success,Packages/passt-selinux-0^20250512.g8ec1341-2.el10.noarch.rpm: No more mirrors to try - All mirrors were already tried without success

so something is not quite right yet :/

Funny. I'm getting the same on #4904. The manifest is generated with image-builder, so it uses librepo, and then the build fails with the same problem.

This will work once osbuild with osbuild/osbuild#2253 is released. this works now.

[achilleas-k]

We should also bump the mimimum osbuild version in the spec file, right?

[mvo5]

Thanks, excellent catch! Updated.