Guild System Missing features

[Tofame]

Missing Guild Related stuff in TFS 1.X:

1. Guild halls.
   Guild halls are houses made by ticking the "Guild hall" option in RME.
   Those houses, when bought, belong to the guild and not to the player.
   When sold, the owner is guild->leader and transfership/items are leader's.
   There are also requirements to keep the ownership of guildhall (pacc etc.).
   Guildhall wiki.

2. Guild Bank is a place where Guild can together deposit money.
   Guild Bank

3. Guild wars conditions to start/end.
   By declaring war [...] sets the conditions: duration (from 7 to 180 days), frag limit (up to 1,000 kills), a penalty payment in case of losing...
   War System

4. No in-game info about war progress, about killing enemies / guildmates dying.
   Quoting wiki: Through guild channel messages you will be informed whenever members of your own guild, or the opposing guild, were killed, and as soon as you won or lost the war.

-- Bonus features that could be implemented, not sure if Tibia has it, so just leaving it here:

• Guild name above head.

==================
My biggest concern:
Neither in TFS nor in database, have I seen a 'frags' for guild war.
So, supposedly, war is started... what about it's duration or 'till X frags'.
There is nothing that would end the war in there, nor distribute reward for wars.

[Wirless]

tofik u have to buy war system like its 2008 from someone prefereably on otland

[Tofame]

tofik u have to buy war system like its 2008 from someone prefereably on otland

I didnt create this issue to get help. I already wrote code for all of this for my particular tfs version && toolset.

The thing is, some parts of the issues were already in-progress but due to lack of interest abandoned or closed in the past. If needed, one might also look at Canary project, they have all of it implemented.

The issue is meant to group all guild/war related missing things so whoever wants to do it can have a reference what to do.

[Wirless]

its proof that the mentality of people has not changed the war system has been the issue that was exploited for so long and sold for so much money probably partly what made mark quit otdev. you won't get it for free unless you write it yourself.

[gesior]

its proof that the mentality of people has not changed the war system has been the issue that was exploited for so long and sold for so much money probably partly what made mark quit otdev. you won't get it for free unless you write it yourself.

Problem with wars on OTSes is that people expect war to start immediately after 'accept' in game/on www and stop when limit of frags is hit.
It does not work that way on RL Tibia. Wars start/end on server save. It cannot work like that with Tibia client, because there is no packet to update emblem of player online, it's even cached in client, when you see given player for first time:

forgottenserver/src/protocolgame.cpp

Lines 3491 to 3493 in 8fe2872

	if (!known) {
	msg.addByte(player->getGuildEmblem(otherPlayer));
	}

OTSes using OTClient added extra packet sendEmblem to update online players emblems, but this code can't be added to official TFS that supports RL Tibia client.

You don't have to pay to get guild wars for a long time:

• 2013: war system management as talkaction for TFS 0.3/0.4:
  https://skalski.pro/files/files/thaiswar860_with_bots/view/data/talkactions/scripts/war.lua

• 2014: war system on website:
  https://otland.net/threads/gesior2012-wars-on-www-tfs-1-0-only-beta-version.209357/
  Lua code needed to finish wars after 7 days is in this otland post.

Not accepted war invitations are already deleted on server restart in TFS:

forgottenserver/data/globalevents/scripts/startup.lua

Line 3 in 8fe2872

db.asyncQuery("DELETE FROM `guild_wars` WHERE `status` = 0")

[Tofame]

OTSes using OTClient added extra packet sendEmblem to update online players emblems, but this code can't be added to official TFS that supports RL Tibia client.

I thought it was a given cip would have that... this makes a lot of things difficult. Maybe one day cipsoft will add it themselves ☹️

[Tofame]

For future references, Zbizu told me that the alternative for lack of sendEmblem packet, is sending creature with 0x61 / 0x62 (ProtocolGame::AddCreature), since it sends emblem in:

	if(!known) {
		msg->put<char>(player->getGuildEmblem(otherPlayer));
	}

But yea, it is probably the best to hope one day Cipsoft adds sendEmblem...