[Bug]: MySQL Error Message: TLS/SSL error: SSL is required, but the server does not support it

[gesior]

By submitting this bug issue, you agree to the following.

• This is a bug in the software that resides in this repository, and not a support matter (use https://otland.net/forums/support.16/ for support)
• This issue is reproducible without changes to the C++ code in this repository
• This bug has not been resolved in master branch
• There is no existing issue for this bug already

Does this bug crash tfs?

no

Server Version

1.7 (Master)

Operation System

all (listed below)

OS Description

No response

Bug description

Server cannot connect to MySQL on server start

Possible Pull Requests which are to blame

• Update vcpkg baseline commit #4932

Steps to reproduce

1. Compile server with vcpkg
2. Try to run server, it fails on connection to MySQL

It was first time reported here: https://otland.net/threads/server-does-not-open-tls-ssl-problem.290112/
In canary it was fixed in 2024.

I have this problem on Ubuntu and Windows when I compile with vcpkg.

Actual Behavior

TFS compiled with vcpkg cannot connect to MySQL/MariaDB without SSL

Expected Behavior

TFS compiled with vcpkg can connect to MySQL/MariaDB without SSL.

Backtrace

[gesior]

Fix from post:
https://otland.net/threads/server-does-not-open-tls-ssl-problem.290112/#post-2775697
does not work on Linux, if you install libmysqlclient-dev (MySQL 8.0), you must install libmariadb-dev-compat(MariaDB connector compatible with MySQL 5.7).

If we add that fix, we must update Linux compilation instructions in wikis ex.: https://github.com/otland/forgottenserver/wiki/Compiling-on-Ubuntu

[alysonjacomin]

@gesior test build with vcpkg in linux using disable ssl:

bellow:

tfs::detail::Mysql_ptr handle{mysql_init(nullptr)};

add:

uint8_t ssl_disabled = 0;
mysql_options(handle.get(), MYSQL_OPT_SSL_VERIFY_SERVER_CERT, &ssl_disabled);

[gesior]

@gesior test build with vcpkg in linux using disable ssl:

uint8_t ssl_disabled = 0; mysql_options(handle.get(), MYSQL_OPT_SSL_VERIFY_SERVER_CERT, &ssl_disabled);

bellow:

detail::Mysql_ptr handle{mysql_init(nullptr)};

This fixes vcpkg build, as vcpkg uses MariaDB libraries on all systems (Linux/Windows/MacOS).

Problems are Linux builds with system libraries (without vcpkg). Some wikis point to apt install libmysqlclient-dev ex. Ubuntu wiki ( https://github.com/otland/forgottenserver/wiki/Compiling-on-Ubuntu ), but it fails to compile.
It works only, if you install libmariadb-dev-compat in place of libmysqlclient-dev, because MYSQL_OPT_SSL_VERIFY_SERVER_CERT is MySQL 5.7/MariaDB constant and default MySQL on Ubuntu 22.04+ and new Linuxes is MySQL 8.0, which deprecated MYSQL_OPT_SSL_VERIFY_SERVER_CERT ( https://dev.mysql.com/doc/c-api/5.7/en/mysql-options.html ):

This option is deprecated as of MySQL 5.7.11 and is removed in MySQL 8.0. Instead, use MYSQL_OPT_SSL_MODE with a value of SSL_MODE_VERIFY_IDENTITY.

Only Arch Linux, Debian and CentOS compilation wikis point to MariaDB library, all other Linux wikis ( https://github.com/otland/forgottenserver/wiki ) point to MySQL library.

EDIT:
If we want to implement this, we should drop MySQL 5.7+ support in:
https://github.com/otland/forgottenserver/blob/c519cc6e6f9864e933c8a5a94d20afee538e70de/cmake/FindMySQL.cmake
and allow only MariaDB and MySQL 5.7
or drop MySQL at all. It's possible that last Linux distro with MySQL 5.7 as default, supports 'boost' library older than 1.71, so it cannot compile TFS as all (even with HTTP - which requires boost 1.75 - disabled).

[alysonjacomin]

I see, but if we stop to analyze this compilation link for Ubuntu it is out of date (for example, it does not contain the installation of "zlib"), when Nekiro added Packet Compression he forgot to update it ...

We need to update these other build methods that don't use vcpkg

[ranisalt]

Checkout #4938 and see if using libmysql instead of libmariadb works. I can't even compile with libmariadb because the code is full of errors

[gesior]

Checkout #4938 and see if using libmysql instead of libmariadb works. I can't even compile with libmariadb because the code is full of errors

You cannot compile current TFS master? What OS? cmake or VS compiler? with vpckg or without?

[ranisalt]

You cannot compile current TFS master? What OS? cmake or VS compiler? with vpckg or without?

Arch Linux, CMake 4.0.3 with vcpkg. There's an issue within libmariadb where it redefines bool using typedef but C already has bool, this is a super outdated practice that should be guarded by compile time checks

Change Dir: '~/.local/share/vcpkg/buildtrees/libmariadb/x64-linux-dbg'

Run Build Command(s): /usr/bin/ninja -v -v -j17 install
[1/85] /usr/bin/cc -DHAVE_OPENSSL -DHAVE_TLS -DLIBICONV_PLUG -DMARIADB_MACHINE_TYPE=\"x86_64\" -DMARIADB_SYSTEM_TYPE=\"Linux\" -I~/Documents/forgottenserver/build/vcpkg_installed/x64-linux/include -I~/.local/share/vcpkg/buildtrees/libmariadb/x64-linux-dbg/include -I~/.local/share/vcpkg/buildtrees/libmariadb/src/v3.4.5-e8c0c6b762.clean/plugins/auth -I~/.local/share/vcpkg/buildtrees/libmariadb/src/v3.4.5-e8c0c6b762.clean/include -I~/.local/share/vcpkg/buildtrees/libmariadb/src/v3.4.5-e8c0c6b762.clean/plugins/auth/ref10 -I~/.local/share/vcpkg/buildtrees/libmariadb/src/v3.4.5-e8c0c6b762.clean/plugins/compress -I~/.local/share/vcpkg/buildtrees/libmariadb/src/v3.4.5-e8c0c6b762.clean/plugins/pvio -I~/.local/share/vcpkg/buildtrees/libmariadb/src/v3.4.5-e8c0c6b762.clean/libmariadb -fPIC -Wunused -Wlogical-op -Wno-uninitialized -Wall -Wextra -Wformat-security -Wno-init-self -Wwrite-strings -Wshift-count-overflow -Wdeclaration-after-statement -Wno-undef -Wno-unknown-pragmas -Wno-stringop-truncation -Werror -g   -D HAVE_COMPRESS -D LIBMARIADB -D THREAD -fPIC -MD -MT libmariadb/CMakeFiles/mariadb_obj.dir/ma_array.c.o -MF libmariadb/CMakeFiles/mariadb_obj.dir/ma_array.c.o.d -o libmariadb/CMakeFiles/mariadb_obj.dir/ma_array.c.o -c ~/.local/share/vcpkg/buildtrees/libmariadb/src/v3.4.5-e8c0c6b762.clean/libmariadb/ma_array.c
FAILED: libmariadb/CMakeFiles/mariadb_obj.dir/ma_array.c.o 
/usr/bin/cc -DHAVE_OPENSSL -DHAVE_TLS -DLIBICONV_PLUG -DMARIADB_MACHINE_TYPE=\"x86_64\" -DMARIADB_SYSTEM_TYPE=\"Linux\" -I~/Documents/forgottenserver/build/vcpkg_installed/x64-linux/include -I~/.local/share/vcpkg/buildtrees/libmariadb/x64-linux-dbg/include -I~/.local/share/vcpkg/buildtrees/libmariadb/src/v3.4.5-e8c0c6b762.clean/plugins/auth -I~/.local/share/vcpkg/buildtrees/libmariadb/src/v3.4.5-e8c0c6b762.clean/include -I~/.local/share/vcpkg/buildtrees/libmariadb/src/v3.4.5-e8c0c6b762.clean/plugins/auth/ref10 -I~/.local/share/vcpkg/buildtrees/libmariadb/src/v3.4.5-e8c0c6b762.clean/plugins/compress -I~/.local/share/vcpkg/buildtrees/libmariadb/src/v3.4.5-e8c0c6b762.clean/plugins/pvio -I~/.local/share/vcpkg/buildtrees/libmariadb/src/v3.4.5-e8c0c6b762.clean/libmariadb -fPIC -Wunused -Wlogical-op -Wno-uninitialized -Wall -Wextra -Wformat-security -Wno-init-self -Wwrite-strings -Wshift-count-overflow -Wdeclaration-after-statement -Wno-undef -Wno-unknown-pragmas -Wno-stringop-truncation -Werror -g   -D HAVE_COMPRESS -D LIBMARIADB -D THREAD -fPIC -MD -MT libmariadb/CMakeFiles/mariadb_obj.dir/ma_array.c.o -MF libmariadb/CMakeFiles/mariadb_obj.dir/ma_array.c.o.d -o libmariadb/CMakeFiles/mariadb_obj.dir/ma_array.c.o -c ~/.local/share/vcpkg/buildtrees/libmariadb/src/v3.4.5-e8c0c6b762.clean/libmariadb/ma_array.c
In file included from ~/.local/share/vcpkg/buildtrees/libmariadb/src/v3.4.5-e8c0c6b762.clean/libmariadb/ma_array.c:23:
~/.local/share/vcpkg/buildtrees/libmariadb/src/v3.4.5-e8c0c6b762.clean/include/ma_global.h:687:25: error: ‘bool’ cannot be defined via ‘typedef’
  687 | typedef char            bool;   /* Ordinary boolean values 0 1 */
      |                         ^~~~
~/.local/share/vcpkg/buildtrees/libmariadb/src/v3.4.5-e8c0c6b762.clean/include/ma_global.h:687:25: note: ‘bool’ is a keyword with ‘-std=c23’ onwards
~/.local/share/vcpkg/buildtrees/libmariadb/src/v3.4.5-e8c0c6b762.clean/include/ma_global.h:687:1: error: useless type name in empty declaration [-Werror]
  687 | typedef char            bool;   /* Ordinary boolean values 0 1 */
      | ^~~~~~~
cc1: all warnings being treated as errors

[gesior]

Arch Linux, CMake 4.0.3 with vcpkg.

I tried it in docker and build fails on Arch with vcpkg.
It will probably fail on all OSes with gcc 15 that supports C++ 23:
https://gcc.gnu.org/gcc-15/porting_to.html#c23-new-keywords
I will try to compile it on Ubuntu 25.04 with g++ 15. Then I will check commit with mysql/mariadb selection.

Edit:
I tried to compile on Ubuntu 25.10 with g++ 15 and it failed the same way.

[Tofame]

When I heard it started happening to users, also happened to me while using another engine I did what canary did:
mysql_options(handle, MYSQL_OPT_SSL_VERIFY_SERVER_CERT, &ssl_enabled);
I'd say the ssl_enabled boolean, could be taken from config.lua. So users have option to either disable it (for example on localhost) or have it enabled if they wish.

[gesior]

MYSQL_OPT_SSL_VERIFY_SERVER_CERT

MYSQL_OPT_SSL_VERIFY_SERVER_CERT this line won't compile with "MySQL 8.0 connection library" :(

MariaDB library from vcpkg does not compile on new compilers (C++23).

Probably final solution will be to merge #4938 (requires more testing) and add this line mysql_options(handle, MYSQL_OPT_SSL_VERIFY_SERVER_CERT, &ssl_enabled); with some library type or library version verification (random version of libraries in examples, it must be tested on multiple OSes with and without vcpkg):

#if defined(MARIADB_VERSION_ID)
  #if MARIADB_VERSION_ID < 10000*3 + 100*1 + 0
(...)
#elif defined(MYSQL_VERSION_ID)
  #if MYSQL_VERSION_ID < 50700
(...)

[Tofame]

MYSQL_OPT_SSL_VERIFY_SERVER_CERT this line won't compile with "MySQL 8.0 connection library" :(

Try from https://dev.mysql.com/doc/c-api/8.0/en/mysql-options.html
MYSQL_OPT_SSL_MODE with value SSL_MODE_DISABLED

They do differ, mariaDB and mssql, so ye, there will be #if definitions needed.