better error logging

Author: Marlinski

shai-http/src/apis/openai/completion/handler.rs

@@ -56,16 +56,22 @@ pub async fn handle_chat_completion(
             }
             // Log tool calls
             AgentEvent::ToolCallStarted { call, .. } => {
-                info!("[{}] TOOL {}", session_id, call.tool_name);
+                info!("[{}] ToolCall: {}", session_id, call.tool_name);
             }
             AgentEvent::ToolCallCompleted { call, result, .. } => {
                 use shai_core::tools::ToolResult;
-                let status = match &result {
-                    ToolResult::Success { .. } => "✓",
-                    ToolResult::Error { .. } => "✗",
-                    ToolResult::Denied => "⊘",
-                };
-                info!("[{}] TOOL {} {}", session_id, call.tool_name, status);
+                match &result {
+                    ToolResult::Success { .. } => {
+                        info!("[{}] ToolResult: {} ✓", session_id, call.tool_name);
+                    }
+                    ToolResult::Error { error, .. } => {
+                        let error_oneline = error.lines().next().unwrap_or(error);
+                        info!("[{}] ToolResult: {} ✗ {}", session_id, call.tool_name, error_oneline);
+                    }
+                    ToolResult::Denied => {
+                        info!("[{}] ToolResult: {} ⊘ Permission denied", session_id, call.tool_name);
+                    }
+                }
             }
             // Agent completed or paused - return the result
             AgentEvent::Completed { message, success, .. } => {

shai-http/src/apis/openai/response/handler.rs

@@ -111,7 +111,7 @@ fn create_response_event_stream(
                                     }
                                     // Tool calls
                                     AgentEvent::ToolCallStarted { call, .. } => {
-                                        info!("[{}] TOOL {}", session_id_str, call.tool_name);
+                                        info!("[{}] ToolCall: {}", session_id_str, call.tool_name);
 
                                         let tool_output = ResponseOutput::FunctionToolCall(FunctionToolCall {
                                             id: call.tool_call_id.clone(),
@@ -134,15 +134,16 @@ fn create_response_event_stream(
 
                                         let tool_status = match &result {
                                             ToolResult::Success { .. } => {
-                                                info!("[{}] TOOL {} ✓", session_id_str, call.tool_name);
+                                                info!("[{}] ToolResult: {} ✓", session_id_str, call.tool_name);
                                                 InputItemStatus::Completed
                                             }
-                                            ToolResult::Error { .. } => {
-                                                info!("[{}] TOOL {} ✗", session_id_str, call.tool_name);
+                                            ToolResult::Error { error, .. } => {
+                                                let error_oneline = error.lines().next().unwrap_or(error);
+                                                info!("[{}] ToolResult: {} ✗ {}", session_id_str, call.tool_name, error_oneline);
                                                 InputItemStatus::Incomplete
                                             }
                                             ToolResult::Denied => {
-                                                info!("[{}] TOOL {} ⊘", session_id_str, call.tool_name);
+                                                info!("[{}] ToolResult: {} ⊘ Permission denied", session_id_str, call.tool_name);
                                                 InputItemStatus::Incomplete
                                             }
                                         };

shai-http/src/apis/simple/handler.rs

@@ -259,16 +259,22 @@ fn log_agent_event(session_id: &Uuid, event: &AgentEvent) {
             debug!("[{}] BrainResult", session_id);
         }
         AgentEvent::ToolCallStarted { call, .. } => {
-            info!("[{}] TOOL {}", session_id, call.tool_name);
+            info!("[{}] ToolCall: {}", session_id, call.tool_name);
         }
         AgentEvent::ToolCallCompleted { call, result, .. } => {
             use shai_core::tools::ToolResult;
-            let status = match result {
-                ToolResult::Success { .. } => "✓",
-                ToolResult::Error { .. } => "✗",
-                ToolResult::Denied => "⊘",
-            };
-            info!("[{}] TOOL {} {}", session_id, call.tool_name, status);
+            match result {
+                ToolResult::Success { .. } => {
+                    info!("[{}] ToolResult: {} ✓", session_id, call.tool_name);
+                }
+                ToolResult::Error { error, .. } => {
+                    let error_oneline = error.lines().next().unwrap_or(error);
+                    info!("[{}] ToolResult: {} ✗ {}", session_id, call.tool_name, error_oneline);
+                }
+                ToolResult::Denied => {
+                    info!("[{}] ToolResult: {} ⊘ Permission denied", session_id, call.tool_name);
+                }
+            }
         }
         AgentEvent::Completed { success, .. } => {
             info!("[{}] Completed: {}", session_id, if *success { "success" } else { "failed" });