Skip to content

Commit 993df0e

Browse files
committed
remove human readable texts from GUI element identifiers
1 parent 2f15b2a commit 993df0e

File tree

6 files changed

+3
-13
lines changed

6 files changed

+3
-13
lines changed

test/gui/shared/scripts/names.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@
3838
advancedConfigGroupBox_syncModeGroupBox_QGroupBox = {"container": contentWidget_advancedConfigGroupBox_QGroupBox, "name": "syncModeGroupBox", "type": "QGroupBox", "visible": 1}
3939
add_Folder_Sync_Connection_OCC_FolderWizard = {"type": "OCC::FolderWizard", "unnamed": 1, "visible": 1, "windowTitle": "Add Folder Sync Connection"}
4040
add_Folder_Sync_Connection_groupBox_QGroupBox = {"name": "groupBox", "type": "QGroupBox", "visible": 1, "window": add_Folder_Sync_Connection_OCC_FolderWizard}
41-
add_Folder_Sync_Connection_Deselect_remote_folders_you_do_not_wish_to_synchronize_QLabel = {"text": "Deselect remote folders you do not wish to synchronize.", "type": "QLabel", "unnamed": 1, "visible": 1, "window": add_Folder_Sync_Connection_OCC_FolderWizard}
42-
folder_Sync_Connection_Deselect_remote_folders_QTreeWidget = {"aboveWidget": add_Folder_Sync_Connection_Deselect_remote_folders_you_do_not_wish_to_synchronize_QLabel, "type": "QTreeWidget", "unnamed": 1, "visible": 1, "window": add_Folder_Sync_Connection_OCC_FolderWizard}
41+
folder_Sync_Connection_Deselect_remote_folders_QTreeWidget = {"type": "QTreeWidget", "unnamed": 1, "visible": 1, "window": add_Folder_Sync_Connection_OCC_FolderWizard}
4342
deselect_remote_folders_you_do_not_wish_to_synchronize_ownCloud_QModelIndex = {"column": 0, "container": folder_Sync_Connection_Deselect_remote_folders_QTreeWidget, "type": "QModelIndex"}
4443
loginRequiredDialog_OCC_LoginRequiredDialog = {"name": "LoginRequiredDialog", "type": "OCC::LoginRequiredDialog", "visible": 1}
4544
loginRequiredDialog_contentWidget_QStackedWidget = {"name": "contentWidget", "type": "QStackedWidget", "visible": 1, "window": loginRequiredDialog_OCC_LoginRequiredDialog}
@@ -65,6 +64,4 @@
6564
stackedWidget_groupBox_QGroupBox = {"container": settings_stack_QStackedWidget, "name": "groupBox", "type": "QGroupBox", "visible": 1}
6665
groupBox_OCC_QmlUtils_OCQuickWidget = {"container": stackedWidget_groupBox_QGroupBox, "type": "OCC::QmlUtils::OCQuickWidget", "unnamed": 1, "visible": 1}
6766
welcome_to_ownCloud_OCC_NewAccountWizard = {"type": "OCC::NewAccountWizard", "unnamed": 1, "visible": 1, "windowTitle": "Add account..."}
68-
server_address_QLabel = {"text": "Enter your server address to get started. Your web browser will be opened to complete sign in.", "type": "QLabel", "unnamed": 1, "visible": 1, "window": welcome_to_ownCloud_OCC_NewAccountWizard}
6967
leave_screen_QLabel = {"text": "Leave this screen open. A sign in prompt will appear in your web browser to connect you to the following address.", "type": "QLabel", "unnamed": 1, "visible": 1, "window": welcome_to_ownCloud_OCC_NewAccountWizard}
70-
welcome_to_ownCloud_Folder_location_QLabel = {"text": "Download location", "type": "QLabel", "unnamed": 1, "visible": 1, "window": welcome_to_ownCloud_OCC_NewAccountWizard}

test/gui/shared/scripts/pageObjects/AccountConnectionWizard.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
class AccountConnectionWizard:
1616
SERVER_ADDRESS_BOX = {
17-
"aboveWidget": names.server_address_QLabel,
1817
"type": "QLineEdit",
1918
"unnamed": 1,
2019
"visible": 1,
@@ -64,7 +63,6 @@ class AccountConnectionWizard:
6463
"visible": True,
6564
}
6665
SELECT_LOCAL_FOLDER = {
67-
"aboveWidget": names.welcome_to_ownCloud_Folder_location_QLabel,
6866
"type": "QLineEdit",
6967
"unnamed": 1,
7068
"visible": 1,
@@ -102,7 +100,6 @@ class AccountConnectionWizard:
102100
"window": names.welcome_to_ownCloud_OCC_NewAccountWizard,
103101
}
104102
COPY_URL_TO_CLIPBOARD_BUTTON = {
105-
"aboveWidget": names.leave_screen_QLabel,
106103
"type": "QPushButton",
107104
"unnamed": 1,
108105
"visible": 1,

test/gui/shared/scripts/pageObjects/AccountSetting.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class AccountSetting:
4545
"visible": 1,
4646
"window": names.settings_OCC_SettingsDialog,
4747
}
48-
CONFIRMATION_YES_BUTTON = {"text": "Yes", "type": "QPushButton", "visible": 1}
48+
CONFIRMATION_YES_BUTTON = {"type": "QPushButton", "visible": 1}
4949

5050
@staticmethod
5151
def account_action(action):

test/gui/shared/scripts/pageObjects/EnterPassword.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ class EnterPassword:
5353
"visible": 1,
5454
}
5555
ACCEPT_CERTIFICATE_YES = {
56-
"text": "Yes",
5756
"type": "QPushButton",
5857
"visible": 1,
5958
"window": TLS_CERT_WINDOW,

test/gui/shared/scripts/pageObjects/SyncConnection.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,26 +36,22 @@ class SyncConnection:
3636
"visible": 1,
3737
}
3838
DISABLE_VFS_CONFIRMATION_BUTTON = {
39-
"text": "Disable support",
4039
"type": "QPushButton",
4140
"visible": 1,
4241
"window": names.disable_virtual_file_support_QMessageBox,
4342
}
4443
SELECTIVE_SYNC_OK_BUTTON = {
4544
"container": names.settings_stack_QStackedWidget,
46-
"text": "OK",
4745
"type": "QPushButton",
4846
"visible": 1,
4947
}
5048
CANCEL_FOLDER_SYNC_CONNECTION_DIALOG = {
51-
"text": "Cancel",
5249
"type": "QPushButton",
5350
"unnamed": 1,
5451
"visible": 1,
5552
"window": names.confirm_Folder_Sync_Connection_Removal_QMessageBox,
5653
}
5754
REMOVE_FOLDER_SYNC_CONNECTION_BUTTON = {
58-
"text": "Remove Folder Sync Connection",
5955
"type": "QPushButton",
6056
"unnamed": 1,
6157
"visible": 1,

test/gui/shared/scripts/pageObjects/SyncConnectionWizard.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ class SyncConnectionWizard:
2727
"text": "< &Back",
2828
"visible": 1,
2929
}
30+
3031
NEXT_BUTTON = {
3132
"window": names.add_Folder_Sync_Connection_OCC_FolderWizard,
3233
"type": "QPushButton",

0 commit comments

Comments
 (0)