Skip to content

Conversation

@DeepDiver1975
Copy link
Member

No description provided.

@DeepDiver1975
Copy link
Member Author

WTF?

image

@saw-jan
Copy link
Member

saw-jan commented Dec 9, 2024

client build failed because of some deprecation warnings:
https://drone.owncloud.com/owncloud/client/19992/4/3

[239/452] Building CXX object src/gui/CMakeFiles/owncloudGui.dir/activitywidget.cpp.o
/drone/src/src/gui/activitywidget.cpp:90:34: warning: 'qAsConst<QMap<QString, OCC::NotificationWidget *>>' is deprecated: Use std::as_const() instead. [-Wdeprecated-declarations]
   90 |         for (const auto widget : qAsConst(_widgetForNotifId)) {

@saw-jan
Copy link
Member

saw-jan commented Dec 9, 2024

might be the unmatched system libraries in owncloud-ci/client

@DeepDiver1975
Copy link
Member Author

I am actually considering to move this step over to GitHub.....

@saw-jan
Copy link
Member

saw-jan commented Dec 9, 2024

I am actually considering to move this step over to GitHub.....

yeeah, maybe we could rely on ctest in github actions

@DeepDiver1975
Copy link
Member Author

@saw-jan you want to work on that?

@saw-jan
Copy link
Member

saw-jan commented Dec 9, 2024

@saw-jan you want to work on that?

yep, I can. I will remove the drone pipeline for ctest in this PR. That means we no longer use owncloudci/client image

@DeepDiver1975
Copy link
Member Author

ctest is already being executed in github workflow -

& "${env:GITHUB_WORKSPACE}/.github/workflows/.craft.ps1" -c --no-cache --test owncloud/owncloud-client

@saw-jan
Copy link
Member

saw-jan commented Dec 9, 2024

ctest is already being executed in github workflow -

& "${env:GITHUB_WORKSPACE}/.github/workflows/.craft.ps1" -c --no-cache --test owncloud/owncloud-client

yeah, then I will remove ctest pipeline in drone. It has been removed
Thanks 👍

@DeepDiver1975 DeepDiver1975 merged commit d49533e into master Dec 9, 2024
6 checks passed
@DeepDiver1975 DeepDiver1975 deleted the feat/qt6.7 branch December 9, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants