tightened up eslint semicolons

eslinting

Author: bmuenzenmeyer

.eslintrc

@@ -67,7 +67,7 @@
     "no-with": 2,
     "quotes": [0, "single"],
     "radix": 2,
-    "semi": [0, "never"],
+    "semi": [1, "always"],
     "strict": 0,
     "space-before-blocks": 1,
     "space-before-function-paren": [1, {

core/lib/annotation_exporter.js

@@ -59,11 +59,11 @@ var annotations_exporter = function (pl) {
     //take the annotation snippets and split them on our custom delimiter
       var annotationsYAML = annotationsMD.split('~*~');
       for (var i = 0; i < annotationsYAML.length; i++) {
-        var annotation = buildAnnotationMD(annotationsYAML[i], markdown_parser)
+        var annotation = buildAnnotationMD(annotationsYAML[i], markdown_parser);
         annotations.push(annotation);
       }
       return false;
-    }
+    };
   }
 
   /*
@@ -72,7 +72,7 @@ var annotations_exporter = function (pl) {
   function parseAnnotationsMD() {
     var markdown_parser = new mp();
     var annotations = [];
-    var mdFiles = glob.sync(paths.source.annotations + '/*.md')
+    var mdFiles = glob.sync(paths.source.annotations + '/*.md');
 
     mdFiles.forEach(parseMDFile(annotations, markdown_parser));
     return annotations;

core/lib/pattern_assembler.js

@@ -520,7 +520,7 @@ var pattern_assembler = function () {
       parseDataLinks(patternlab);
     },
     parse_data_links_specific: function (patternlab, data, label) {
-      return parseDataLinksHelper(patternlab, data, label)
+      return parseDataLinksHelper(patternlab, data, label);
     },
     parse_pattern_markdown: function (pattern, patternlab) {
       parsePatternMarkdown(pattern, patternlab);

core/lib/patternlab.js

@@ -14,6 +14,7 @@ var diveSync = require('diveSync'),
   glob = require('glob'),
   _ = require('lodash'),
   path = require('path'),
+  pm = require('./plugin_manager'),
   plutils = require('./utilities');
 
 function buildPatternData(dataFilesPath, fs) {
@@ -74,6 +75,19 @@ function checkConfiguration(patternlab) {
   patternlab.config.outputFileSuffixes = _.extend(outputFileSuffixes, patternlab.config.outputFileSuffixes);
 }
 
+function initializePlugins(patternlab) {
+  var plugin_manager = new pm(patternlab.config, path.resolve(__dirname, '../../patternlab-config.json'));
+  var foundPlugins = plugin_manager.detect_plugins();
+
+  if (foundPlugins && foundPlugins.length > 0) {
+
+    for (var i = 0; i < foundPlugins.length; i++) {
+      var plugin = plugin_manager.load_plugin(foundPlugins[i]);
+      plugin(patternlab);
+    }
+  }
+}
+
 var patternlab_engine = function (config) {
   'use strict';
 
@@ -84,7 +98,6 @@ var patternlab_engine = function (config) {
     lh = require('./lineage_hunter'),
     ui = require('./ui_builder'),
     sm = require('./starterkit_manager'),
-    pm = require('./plugin_manager'),
     patternlab = {};
 
   patternlab.package = fs.readJSONSync(path.resolve(__dirname, '../../package.json'));
@@ -172,19 +185,6 @@ var patternlab_engine = function (config) {
     }
   }
 
-  function initializePlugins(patternlab) {
-    var plugin_manager = new pm(patternlab.config, path.resolve(__dirname, '../../patternlab-config.json'));
-    var foundPlugins = plugin_manager.detect_plugins();
-
-    if (foundPlugins && foundPlugins.length > 0) {
-
-      for (var i = 0; i < foundPlugins.length; i++) {
-        var plugin = plugin_manager.load_plugin(foundPlugins[i]);
-        plugin(patternlab);
-      }
-    }
-  }
-
   function setCacheBust() {
     if (patternlab.config.cacheBust) {
       if (patternlab.config.debug) {

core/lib/plugin_manager.js

@@ -3,12 +3,10 @@
 var plugin_manager = function (config, configPath) {
   var path = require('path'),
     fs = require('fs-extra'),
-    util = require('./utilities'),
-    paths = config.paths;
+    util = require('./utilities');
 
   function loadPlugin(pluginName) {
-    var pluginInstance = require(path.join(process.cwd(), 'node_modules', pluginName));
-    return pluginInstance;
+    return require(path.join(process.cwd(), 'node_modules', pluginName));
   }
 
   function installPlugin(pluginName) {
@@ -39,11 +37,10 @@ var plugin_manager = function (config, configPath) {
 
   function detectPlugins() {
     var node_modules_path = path.join(process.cwd(), 'node_modules');
-    var npm_modules = fs.readdirSync(node_modules_path).filter(function (dir) {
+    return fs.readdirSync(node_modules_path).filter(function (dir) {
       var module_path = path.join(process.cwd(), 'node_modules', dir);
       return fs.statSync(module_path).isDirectory() && dir.indexOf('plugin-node-') === 0;
     });
-    return npm_modules;
   }
 
   function disablePlugin(pluginName) {
@@ -55,7 +52,7 @@ var plugin_manager = function (config, configPath) {
   }
 
   return {
-    install_plugin: function(pluginName) {
+    install_plugin: function (pluginName) {
       installPlugin(pluginName);
     },
     load_plugin: function (pluginName) {

core/lib/ui_builder.js

@@ -235,7 +235,7 @@ var ui_builder = function () {
       patternState: pattern.patternState,
       patternSrcPath: encodeURI(pattern.subdir + '/' + pattern.fileName),
       patternPath: patternPath
-    }
+    };
   }
 
   /**
@@ -618,7 +618,7 @@ var ui_builder = function () {
 
   return {
     buildFrontend: function (patternlab) {
-      buildFrontend(patternlab)
+      buildFrontend(patternlab);
     },
     isPatternExcluded: function (pattern, patternlab) {
       return isPatternExcluded(pattern, patternlab);