From 74686e9e6dff741dce7a0f29915b81cd1f6db72a Mon Sep 17 00:00:00 2001 From: Karl Rister Date: Wed, 20 May 2026 09:48:04 -0500 Subject: [PATCH 1/2] fix: add permissions and broader event types to fork-check workflow The fork-check workflow needs issues:write and pull-requests:write permissions to comment on and close fork PRs. Without these, the GITHUB_TOKEN for pull_request_target events from forks only has read permissions, causing the API calls to fail with 403. Also add synchronize and edited event types so the workflow triggers on existing fork PRs when commits are pushed or the PR is edited, not just on initial open/reopen. Co-Authored-By: Claude Opus 4.6 (1M context) --- .github/workflows/fork-check.yaml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/fork-check.yaml b/.github/workflows/fork-check.yaml index 2934d35..261f072 100644 --- a/.github/workflows/fork-check.yaml +++ b/.github/workflows/fork-check.yaml @@ -2,7 +2,11 @@ name: fork-check on: pull_request_target: - types: [opened, reopened] + types: [opened, reopened, synchronize, edited] + +permissions: + issues: write + pull-requests: write jobs: block-fork-pr: From 71a13ab21fbaffe8349b18404e00210b6fd6639b Mon Sep 17 00:00:00 2001 From: Karl Rister Date: Wed, 20 May 2026 09:48:04 -0500 Subject: [PATCH 2/2] fix: use only_modified instead of only_changed in CI workflows The tj-actions/changed-files only_changed output does not include deleted files, causing CI to be skipped when a PR only deletes non-doc files. Switch to only_modified which correctly includes deletions. Co-Authored-By: Claude Opus 4.6 (1M context) --- .github/workflows/crucible-ci.yaml | 2 +- .github/workflows/unittest.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/crucible-ci.yaml b/.github/workflows/crucible-ci.yaml index 48272d8..04570f6 100644 --- a/.github/workflows/crucible-ci.yaml +++ b/.github/workflows/crucible-ci.yaml @@ -13,7 +13,7 @@ jobs: changes: runs-on: ubuntu-latest outputs: - only-docs: ${{ steps.filter.outputs.only_changed }} + only-docs: ${{ steps.filter.outputs.only_modified }} steps: - uses: actions/checkout@v4 - id: filter diff --git a/.github/workflows/unittest.yaml b/.github/workflows/unittest.yaml index e992bd8..b7b6a51 100644 --- a/.github/workflows/unittest.yaml +++ b/.github/workflows/unittest.yaml @@ -13,7 +13,7 @@ jobs: changes: runs-on: ubuntu-latest outputs: - only-docs: ${{ steps.filter.outputs.only_changed }} + only-docs: ${{ steps.filter.outputs.only_modified }} steps: - uses: actions/checkout@v4 - id: filter