Skip to content

Commit f04fb8c

Browse files
Apply suggestions from code review
Co-authored-by: Shingo Omura <[email protected]>
1 parent 2b99cf7 commit f04fb8c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

pkg/backend/config/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ type RedisClientConfig struct {
5454
IdleCheckFrequency time.Duration `json:"idleCheckFrequency" yaml:"idleCheckFrequency" default:"1m"`
5555

5656
ChunkSizeInGet int `json:"chunkSizeInGet" yaml:"chunkSizeInGet" default:"10000"`
57-
ChunkSizeInDelete int `json:"chunkSizeInDelete" yaml:"chunkSizeInGet" default:"1000"`
57+
ChunkSizeInDelete int `json:"chunkSizeInDelete" yaml:"chunkSizeInDelete" default:"1000"`
5858
}
5959

6060
func (c RedisClientConfig) NewClient() *redis.Client {

pkg/backend/redis/queue.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ func (b *Backend) DeleteQueue(ctx context.Context, queueName string) error {
218218
// .. task_keys = collect task keys
219219
// WATCh task_keys
220220
// MULTI
221-
// UNLINK {queue_key} worker_keys task_keys
221+
// UNLINK {queue_key} worker_keys task_keys (chunked)
222222
// HDEL {all_queues_key} {queueName}
223223
// EXEC
224224
txf := func(tx *redis.Tx) error {
@@ -240,7 +240,7 @@ func (b *Backend) DeleteQueue(ctx context.Context, queueName string) error {
240240
tx.Watch(taskKeysToDelete...)
241241
keysToDelete = append(keysToDelete, taskKeysToDelete...)
242242

243-
chunkSize := b.ChunkSizeInGet
243+
chunkSize := b.ChunkSizeInDelete
244244
numOfKeysToDelete := len(keysToDelete)
245245
_, err = tx.TxPipelined(func(pipe redis.Pipeliner) error {
246246
for begin := 0; begin < numOfKeysToDelete; begin += chunkSize {

0 commit comments

Comments
 (0)