Skip to content

Add exclude_rows argument to g_forest() (Solves #1498). - #1503

Open
wwojciech wants to merge 2 commits into
pharmaverse:mainfrom
wwojciech:1498_g_forest()_exclude_rows
Open

Add exclude_rows argument to g_forest() (Solves #1498).#1503
wwojciech wants to merge 2 commits into
pharmaverse:mainfrom
wwojciech:1498_g_forest()_exclude_rows

Conversation

@wwojciech

@wwojciech wwojciech commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Fixes #1498

@wwojciech

wwojciech commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Hi @gmbecker - I created this PR following your advice. However, I noticed that some of the checks are failing during the CLA step.

@gmbecker, @danielinteractive - could you add yourselves as reviewers for this PR?

@wwojciech

wwojciech commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Hi Dinakar (@cicdguy), do you know why the automated checks failed here?

danielinteractive
danielinteractive reviewed Jul 28, 2026
View reviewed changes

@danielinteractive danielinteractive left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wwojciech , please see comments below

Comment thread R/g_forest.R Outdated
Comment thread R/g_forest.R Outdated
Comment thread R/g_forest.R Outdated
Comment thread R/g_forest.R
Comment thread R/g_forest.R
@wwojciech

wwojciech commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, @danielinteractive - I replied to your questions. Regarding the other suggestion, I will apply it soon, as you suggested.

danielinteractive
danielinteractive approved these changes Jul 31, 2026
View reviewed changes

@danielinteractive danielinteractive left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @wwojciech !

@wwojciech

wwojciech commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

Looks good to me, thanks @wwojciech !

Thank you @danielinteractive . Can you pl. merge it? I have no writing rights.

@danielinteractive

danielinteractive commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

@wwojciech I cannot either. @Melkiades and @shajoezhu , could you help us?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielinteractive danielinteractive danielinteractive approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Allow excluding rows from the g_forest().

2 participants

@wwojciech @danielinteractive