Update the rtx_timer to RFC 9260 #403
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipch07
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #403 +/- ##
==========================================
+ Coverage 83.84% 84.02% +0.18%
==========================================
Files 51 51
Lines 3448 3469 +21
==========================================
+ Hits 2891 2915 +24
+ Misses 417 415 -2
+ Partials 140 139 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
philipch07
force-pushed
the
pch07/update-rtx-timer-to-rfc-9260
branch
3 times, most recently
from
680eea2 to
0c980d9
Compare
philipch07
force-pushed
the
pch07/update-rtx-timer-to-rfc-9260
branch
2 times, most recently
from
35efde0 to
b0a3b47
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the SCTP retransmission timer implementation to conform with RFC 9260 (updating from RFC 4960), adds comprehensive test coverage for edge cases and RFC requirements, and fixes spelling errors throughout the test file.
- Implements RFC 9260 clock granularity requirement (G1) for RTTVAR
- Adds backoff persistence logic across timer restarts per RFC 9260 sections 6.3.2 and 6.3.3
- Introduces fuzz testing for RTO manager, timeout calculation, and timer state machine
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rtx_timer.go | Implements RFC 9260 G1 granularity bump for RTTVAR==0, adds restart() and updateBaseRTO() methods for backoff handling, updates RFC references and fixes typos in comments |
| rtx_timer_test.go | Adds unit tests for G1 granularity, backoff persistence, and RFC compliance; fixes spelling of "unexpected" and "after" in error messages; adds three fuzz tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
philipch07
force-pushed
the
pch07/update-rtx-timer-to-rfc-9260
branch
from
b0a3b47 to
7a1fe98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reference issue
A part of #402.