NEW_C4_STYLE components and nodes have a dark (black) impression

[kirchsth]

Components and nodes uses a black font color. Based on that the NEW_C4_STYLE components and nodes have a very dark impression like

based on that NEW_C4_STYLE should not swap the colors if the font color is black like below

[kirchsth]

1. Simple solution, user has to swap the colors on it´s own like below

!NEW_C4_STYLE = 1
!$COMPONENT_BG_COLOR = "#000000"
!$COMPONENT_FONT_COLOR = "#85BBF0"

2. or new theme with the changed lines are defined like

!theme C4_new_blue from ...

3. or the C4_* files and C4 themes makes the changes automatically

4. or C4-Plantuml itself calculates the swap process based on the font-color

5. ... or ??? (one or more better ideas)

@Potherca: I don't like the very specific and color dependent swap rule at all (ex. if a user defines a new tag then depending on the (base) color of the font the $fontColor and $bgColor have to be swapped in the AddElementTag() call (or not). Atm. all *-puml files should work and color changes should remain compatible. But as soon colors are only partly swapped then AddElementTag() would be very confusing. Do you have a better idea?

[Potherca]

I think the most stable solution would be option nr. 3:

the C4_* files and C4 themes makes the changes automatically

That looks the most similar to design patterns in similar UI issues in other domains. For instance how to deal with dark or light mode in CSS. (Define vars at the start and then add exceptions for specific values).

It would require hard-coding the changes across all themes, but would create the least surprises.

Option nr. 4 would require the least code changes (the 5 places where $swap is used) but create more complexity, and possibly unexpected behavior. To fix edge cases more logic would most likely have to be created, making things even more complex.

I feels like a better solution should be possible, but I have not been able to think of one yet... 🤔