Add/update tests

Author: camdecoster

test/jasmine/tests/geo_test.js

@@ -2661,7 +2661,7 @@ describe('Test geo zoom/pan/drag interactions:', function () {
 
             newPlot(fig)
                 .then(function () {
-                    _assert('base', [[undefined, undefined], undefined], [[0.252, -19.8], 160], undefined);
+                    _assert('base', [[undefined, undefined], undefined], [[-76.014, -19.8], 160], undefined);
                     return drag({
                         path: [
                             [250, 250],
@@ -2673,8 +2673,8 @@ describe('Test geo zoom/pan/drag interactions:', function () {
                 .then(function () {
                     _assert(
                         'after east-west drag',
-                        [[-20.32, 21.226], 1],
-                        [[20.32, -21.226], 160],
+                        [[55.99, 21.103], 1],
+                        [[-55.99, -21.103], 160],
                         [
                             'geo.projection.rotation.lon',
                             'geo.projection.rotation.lat',
@@ -2687,17 +2687,17 @@ describe('Test geo zoom/pan/drag interactions:', function () {
                 .then(function () {
                     _assert(
                         'after scroll',
-                        [[-17.5597, 18.862], 1.1488],
-                        [[17.5597, -18.862], 183.818],
+                        [[58.694, 18.759], 1.1488],
+                        [[-58.694, -18.759], 183.818],
                         ['geo.projection.rotation.lon', 'geo.projection.rotation.lat', 'geo.projection.scale']
                     );
                     return Plotly.relayout(gd, 'geo.showocean', false);
                 })
                 .then(function () {
                     _assert(
                         'after some relayout call that causes a replot',
-                        [[-17.5597, 18.862], 1.1488],
-                        [[17.5597, -18.862], 183.818],
+                        [[58.694, 18.759], 1.1488],
+                        [[-58.694, -18.759], 183.818],
                         ['geo.showocean']
                     );
                     return dblClick([350, 250]);
@@ -2707,7 +2707,7 @@ describe('Test geo zoom/pan/drag interactions:', function () {
                     _assert(
                         'after double click',
                         [[undefined, undefined], undefined],
-                        [[0.252, -19.8], 160],
+                        [[-76.014, -19.8], 160],
                         'dblclick'
                     );
                 })
@@ -3162,11 +3162,6 @@ describe('Test geo interactions update marker angles:', function () {
                 expect(newPath).toEqual(
                     'M0,0L18.27769005891461,8.119485581627321L19.559475756661865,-4.174554841483899Z'
                 );
-
-                expect(newPath).not.toEqual(initialPath);
-                expect(newPath).toEqual(
-                    'M0,0L18.27769005891461,8.119485581627321L19.559475756661865,-4.174554841483899Z'
-                );
                 expect(initialPath).toEqual(
                     'M0,0L-1.5094067529528923,19.942960945008643L10.501042615957648,17.021401351764233Z'
                 );

test/jasmine/tests/lib_geo_location_utils_test.js

@@ -1,4 +1,4 @@
-const { getFitboundsLonRange, unwrapLonRange, doesCrossAntiMeridian } = require('../../../src/lib/geo_location_utils');
+const { computeBbox, getFitboundsLonRange, unwrapLonRange, doesCrossAntiMeridian } = require('../../../src/lib/geo_location_utils');
 
 describe('Test geo_location_utils.getFitboundsLonRange', () => {
     it('returns the compact crossing range when point data straddles the antimeridian', () => {
@@ -38,6 +38,69 @@ describe('Test geo_location_utils.unwrapLonRange', () => {
     });
 });
 
+describe('Test geo_location_utils.computeBbox', () => {
+    const franceCCW = { type: 'Polygon', coordinates: [[[-5, 41], [10, 41], [10, 51], [-5, 51], [-5, 41]]] };
+    const franceCW = { type: 'Polygon', coordinates: [[[-5, 41], [-5, 51], [10, 51], [10, 41], [-5, 41]]] };
+    // Fiji-ish narrow band crossing the antimeridian.
+    const fiji = { type: 'Polygon', coordinates: [[[176, -19], [180, -19], [-178, -19], [-178, -16], [180, -16], [176, -16], [176, -19]]] };
+    // Russia-ish MultiPolygon with parts on both sides of ±180.
+    const russia = {
+        type: 'MultiPolygon',
+        coordinates: [
+            [[[30, 55], [170, 55], [170, 75], [30, 75], [30, 55]]],
+            [[[-180, 65], [-170, 65], [-170, 72], [-180, 72], [-180, 65]]]
+        ]
+    };
+
+    it('returns a degenerate bbox for a single Point', () => {
+        expect(computeBbox({ type: 'Point', coordinates: [10, 45] })).toEqual([10, 45, 10, 45]);
+    });
+
+    it('returns a normal bbox for a non-antimeridian polygon', () => {
+        expect(computeBbox(franceCCW)).toEqual([-5, 41, 10, 51]);
+    });
+
+    it('is winding-agnostic (CCW and CW polygons yield the same bbox)', () => {
+        expect(computeBbox(franceCW)).toEqual(computeBbox(franceCCW));
+    });
+
+    it('unwraps east past 180° for a polygon that crosses the antimeridian', () => {
+        expect(computeBbox(fiji)).toEqual([176, -19, 182, -16]);
+    });
+
+    it('unwraps east past 180° for a MultiPolygon that crosses the antimeridian', () => {
+        expect(computeBbox(russia)).toEqual([30, 55, 190, 75]);
+    });
+
+    it('handles a FeatureCollection mixing antimeridian and non-antimeridian features', () => {
+        const fc = {
+            type: 'FeatureCollection',
+            features: [
+                { type: 'Feature', geometry: russia, properties: {} },
+                { type: 'Feature', geometry: franceCCW, properties: {} }
+            ]
+        };
+        expect(computeBbox(fc)).toEqual([-5, 41, 190, 75]);
+    });
+
+    it('unwraps identically whether the input is a raw Geometry or wrapped in a Feature', () => {
+        const raw = computeBbox(russia);
+        const wrapped = computeBbox({ type: 'Feature', geometry: russia, properties: {} });
+        expect(wrapped).toEqual(raw);
+    });
+
+    it('returns null for inputs with no extractable coordinates', () => {
+        expect(computeBbox({ type: 'Sphere' })).toBe(null);
+        expect(computeBbox({ type: 'FeatureCollection', features: [] })).toBe(null);
+    });
+
+    it('returns null for nullish or malformed inputs instead of throwing', () => {
+        expect(computeBbox(null)).toBe(null);
+        expect(computeBbox(undefined)).toBe(null);
+        expect(computeBbox({})).toBe(null);
+    });
+});
+
 describe('Test geo_location_utils.doesCrossAntiMeridian', () => {
     it('returns the index of the first positive-to-negative longitude transition', () => {
         expect(doesCrossAntiMeridian([[170, 0], [179, 0], [-179, 0], [-170, 0]])).toBe(1);