Skip to content

build: Make the runtime a valid 64bit index package #24882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

build: Make the runtime a valid 64bit index package #24882

wants to merge 3 commits into from

Conversation

@JakubValtar
Copy link
Collaborator

@JakubValtar JakubValtar commented Oct 15, 2025 •
edited
Loading

This PR:

  • makes the runtime a valid 64-bit index package that can be built with maturin without any extra build steps
  • this is needed to enable cloud to point to a specific polars revision as a dependency of the python client

cc @ritchie46

@github-actions github-actions bot added build Changes that affect the build system or external dependencies python Related to Python Polars rust Related to Rust Polars labels Oct 15, 2025
coastalwhite
coastalwhite suggested changes Oct 15, 2025
View reviewed changes
Copy link
Collaborator

@coastalwhite coastalwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, this will enable 64-bit for LTS. But we wanted to do that anyway so that is fine.

@JakubValtar
Copy link
Collaborator Author

JakubValtar commented Oct 15, 2025

Note, this will enable 64-bit for LTS. But we wanted to do that anyway so that is fine.

Is it the same thing as rtcompat? It should run the same workflow as rt32.

@JakubValtar JakubValtar marked this pull request as draft October 15, 2025 15:37
@JakubValtar JakubValtar force-pushed the runtime-build-process branch from 250fa9c to d897f84 Compare October 15, 2025 16:37
@JakubValtar JakubValtar mentioned this pull request Oct 15, 2025
Merged
@ritchie46 ritchie46 force-pushed the main branch 3 times, most recently from 90ceb7b to e9fce55 Compare October 26, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

1 more reviewer

@coastalwhite coastalwhite coastalwhite requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

build Changes that affect the build system or external dependencies python Related to Python Polars rust Related to Rust Polars

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JakubValtar @coastalwhite