Display a new unit risk line in the returns/volatility chart view #5080
Conversation
The line can be enabled/disabled via the menu, and offers a visual way to assess the amount of risk taken for an investment, compared to a unit risk
| int x0 = xAxis.getPixelCoordinate(0); | ||
| int y0 = yAxis.getPixelCoordinate(0); | ||
|
|
||
| int x1 = xAxis.getPixelCoordinate(9999); |
There was a problem hiding this comment.
Using 9999 here, I tried to use Double.MAX_VALUE but this didn't work for some reason. Any hint on what to use instead, I can adjust.
In Eclipse, you can run the application with 
|
|
About the feature: I like it.
I also have no better idea. Maybe it is possible to get the "slope" of the curve from both axis and then calculate the pixels. But it looks good enough for. We'll add a comment to remember our future self why this magic number is used... Two questions: First: Shouldn't the line extend into the negative area as well? Second: I would have thought that the unit risk line represents the "risk free asset". Here it is a constant definition. I am just asking myself, if we should allow the configuration of the "risk free return" to determine the slope of the line. And for the share ratio widget, the user can already configure a risk free return that is stored with the file (not per widget, but globally). 
|
Ok, I can do that.
Since the volatility/variance/semivariance aren't supposed to be negative, we shouldn't add a line on the left part of the graph (x < 0). A future enhancement (in a separate PR) would consist in actually hiding this part entirely to the user, because in practice it's never used.
I've been thinking about that yes, and I wasn't sure either. The "risk free return" normally is more a notion of the Sharpe ratio. And since here we can choose different metrics for X (variance/semivariance) and Y (TRI/TTWROR) then it is not obvious to consider that this graph is always linked with the Sharpe ratio. |
2 participants
The line can be enabled/disabled via the menu, and offers a visual way to assess the amount of risk taken for an investment, compared to a unit risk.
Here is the result (note: pictures are displayed in French, despite looking it up on the Internet I didn't find a quick way to override the default language setting from the VM).
Hope this will be useful!