Skip to content

Commit 6785dd7

Browse files
Merge/1.102.0 log location (#8796)
Merges latest changes from upstream `vscode-server`. This is to mainly pull in the change for using XDG_STATE_HOME for logs but has a minor update to the update Workbench workflow action and resolving the require on `compileBuildWithoutManglingTask`. --------- Co-authored-by: positron-bot[bot] <173392469+positron-bot[bot]@users.noreply.github.com>
1 parent 23d5feb commit 6785dd7

File tree

4 files changed

+18
-23
lines changed

4 files changed

+18
-23
lines changed

.github/workflows/update-workbench-version.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
git config user.email "[email protected]"
4141
4242
- name: Create Pull Request
43-
uses: peter-evans/create-pull-request@v6
43+
uses: peter-evans/create-pull-request@v7
4444
with:
4545
token: ${{ env.TOKEN }}
4646
commit-message: "Update PWB Code Server version to ${{ env.VERSION }}"

build/gulpfile.reh.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ const { positronBuildNumber } = require('./utils');
3131
const { copyExtensionBinariesTask } = require('./gulpfile.extensions');
3232
// --- End Positron ---
3333
const { compileBuildWithManglingTask } = require('./gulpfile.compile');
34+
// --- Start PWB ---
35+
const { compileBuildWithoutManglingTask } = require('./gulpfile.compile');
36+
// --- End PWB ---
3437
const { cleanExtensionsBuildTask, compileNonNativeExtensionsBuildTask, compileNativeExtensionsBuildTask, compileExtensionMediaBuildTask } = require('./gulpfile.extensions');
3538
const { vscodeWebResourceIncludes, createVSCodeWebFileContentMapper } = require('./gulpfile.vscode.web');
3639
const cp = require('child_process');
@@ -42,7 +45,6 @@ const commit = getVersion(REPO_ROOT);
4245
const BUILD_ROOT = path.dirname(REPO_ROOT);
4346
const REMOTE_FOLDER = path.join(REPO_ROOT, 'remote');
4447
// --- Start Positron ---
45-
const { compileBuildWithoutManglingTask } = require('./gulpfile.compile');
4648
const REMOTE_REH_WEB_FOLDER = path.join(REPO_ROOT, 'remote', 'reh-web');
4749
// --- End Positron ---
4850

build/secrets/.secrets.baseline

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,10 @@
9494
"path": "detect_secrets.filters.common.is_baseline_file",
9595
"filename": "build/secrets/.secrets.baseline"
9696
},
97+
{
98+
"path": "detect_secrets.filters.common.is_ignored_due_to_verification_policies",
99+
"min_level": 2
100+
},
97101
{
98102
"path": "detect_secrets.filters.heuristic.is_indirect_reference"
99103
},
@@ -1649,16 +1653,6 @@
16491653
"is_secret": false
16501654
}
16511655
],
1652-
"src/vs/workbench/api/node/loopbackServer.ts": [
1653-
{
1654-
"type": "AWS Access Key",
1655-
"filename": "src/vs/workbench/api/node/loopbackServer.ts",
1656-
"hashed_secret": "094ab4147707513f945937285ac0a6ef8472a356",
1657-
"is_verified": false,
1658-
"line_number": 184,
1659-
"is_secret": false
1660-
}
1661-
],
16621656
"src/vs/workbench/api/test/browser/extHostTelemetry.test.ts": [
16631657
{
16641658
"type": "Secret Keyword",
@@ -1727,16 +1721,6 @@
17271721
"is_secret": false
17281722
}
17291723
],
1730-
"src/vs/workbench/services/extensions/browser/webWorkerExtensionHost.ts": [
1731-
{
1732-
"type": "IBM Cloud IAM Key",
1733-
"filename": "src/vs/workbench/services/extensions/browser/webWorkerExtensionHost.ts",
1734-
"hashed_secret": "0d43d6e259826e4ecbda1644424b26de54faa665",
1735-
"is_verified": false,
1736-
"line_number": 96,
1737-
"is_secret": false
1738-
}
1739-
],
17401724
"src/vs/workbench/services/extensions/worker/webWorkerExtensionHostIframe.html": [
17411725
{
17421726
"type": "Base64 High Entropy String",

src/vs/platform/environment/common/environmentService.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,16 @@ export abstract class AbstractNativeEnvironmentService implements INativeEnviron
7373
get logsHome(): URI {
7474
if (!this.args.logsPath) {
7575
const key = toLocalISOString(new Date()).replace(/-|:|\.\d+Z$/g, '');
76-
this.args.logsPath = join(this.userDataPath, 'logs', key);
76+
// --- Start PWB ---
77+
// Change this.args.logsPath from userDataPath to XDG_STATE_HOME if available, otherwise use ~/.local/state for logs
78+
const userStatePath = process.env['XDG_STATE_HOME'];
79+
const productName = this.productService.applicationName;
80+
if (userStatePath) {
81+
this.args.logsPath = join(userStatePath, productName, 'logs', key);
82+
} else {
83+
this.args.logsPath = join(this.paths.homeDir, '.local', 'state', productName, 'logs', key);
84+
}
85+
// --- End PWB ---
7786
}
7887

7988
return URI.file(this.args.logsPath);

0 commit comments

Comments
 (0)