Skip to content

Commit 3f378db

Browse files
committed
Remove redundant functions.
1 parent 308477a commit 3f378db

File tree

6 files changed

+1
-54
lines changed

6 files changed

+1
-54
lines changed

packages/service-core-tests/src/tests/register-data-storage-parameter-tests.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
import { storage } from '@powersync/service-core';
2-
import {
3-
mergeBucketParameterQueriers,
4-
ParameterLookup,
5-
PendingQueriers,
6-
RequestParameters
7-
} from '@powersync/service-sync-rules';
8-
import { SqlBucketDescriptor } from '@powersync/service-sync-rules/src/SqlBucketDescriptor.js';
2+
import { ParameterLookup, RequestParameters } from '@powersync/service-sync-rules';
93
import { expect, test } from 'vitest';
104
import * as test_utils from '../test-utils/test-utils-index.js';
115
import { TEST_TABLE } from './util.js';

packages/sync-rules/src/BucketSource.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,6 @@ export interface BucketParameterSourceDefinition {
5656
getSourceTables(): Set<TablePattern>;
5757
createParameterSource(params: CreateSourceParams): BucketParameterSource;
5858

59-
getSourceTables(): Set<TablePattern>;
60-
6159
/** Whether the table possibly affects the buckets resolved by this source. */
6260
tableSyncsParameters(table: SourceTableInterface): boolean;
6361
}
@@ -110,11 +108,6 @@ export interface BucketParameterSource {
110108
* @param options Options, including parameters that may affect the buckets loaded by this source.
111109
*/
112110
pushBucketParameterQueriers(result: PendingQueriers, options: GetQuerierOptions): void;
113-
114-
/**
115-
* @deprecated Use `pushBucketParameterQueriers` instead and merge at the top-level.
116-
*/
117-
getBucketParameterQuerier(options: GetQuerierOptions): BucketParameterQuerier;
118111
}
119112

120113
export enum BucketSourceType {

packages/sync-rules/src/SqlParameterQuery.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -344,16 +344,6 @@ export class SqlParameterQuery implements BucketParameterSourceDefinition {
344344
pushBucketParameterQueriers: (result: PendingQueriers, options: GetQuerierOptions) => {
345345
const q = this.getBucketParameterQuerier(options.globalParameters, ['default'], params.bucketIdTransformer);
346346
result.queriers.push(q);
347-
},
348-
349-
/**
350-
* @deprecated Use `pushBucketParameterQueriers` instead and merge at the top-level.
351-
*/
352-
getBucketParameterQuerier(options: GetQuerierOptions): BucketParameterQuerier {
353-
const queriers: BucketParameterQuerier[] = [];
354-
this.pushBucketParameterQueriers({ queriers, errors: [] }, options);
355-
356-
return mergeBucketParameterQueriers(queriers);
357347
}
358348
};
359349
}

packages/sync-rules/src/StaticSqlParameterQuery.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -218,16 +218,6 @@ export class StaticSqlParameterQuery implements BucketParameterSourceDefinition
218218
queryDynamicBucketDescriptions: async () => []
219219
} satisfies BucketParameterQuerier;
220220
result.queriers.push(staticQuerier);
221-
},
222-
223-
/**
224-
* @deprecated Use `pushBucketParameterQueriers` instead and merge at the top-level.
225-
*/
226-
getBucketParameterQuerier(options: GetQuerierOptions): BucketParameterQuerier {
227-
const queriers: BucketParameterQuerier[] = [];
228-
this.pushBucketParameterQueriers({ queriers, errors: [] }, options);
229-
230-
return mergeBucketParameterQueriers(queriers);
231221
}
232222
};
233223
}

packages/sync-rules/src/TableValuedFunctionSqlParameterQuery.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -262,16 +262,6 @@ export class TableValuedFunctionSqlParameterQuery implements BucketParameterSour
262262
queryDynamicBucketDescriptions: async () => []
263263
} satisfies BucketParameterQuerier;
264264
result.queriers.push(staticQuerier);
265-
},
266-
267-
/**
268-
* @deprecated Use `pushBucketParameterQueriers` instead and merge at the top-level.
269-
*/
270-
getBucketParameterQuerier(options: GetQuerierOptions): BucketParameterQuerier {
271-
const queriers: BucketParameterQuerier[] = [];
272-
this.pushBucketParameterQueriers({ queriers, errors: [] }, options);
273-
274-
return mergeBucketParameterQueriers(queriers);
275265
}
276266
};
277267
}

packages/sync-rules/src/streams/stream.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -118,16 +118,6 @@ export class SyncStream implements BucketDataSourceDefinition, BucketParameterSo
118118
}
119119

120120
return result;
121-
},
122-
123-
/**
124-
* @deprecated Use `pushBucketParameterQueriers` instead and merge at the top-level.
125-
*/
126-
getBucketParameterQuerier(options: GetQuerierOptions): BucketParameterQuerier {
127-
const queriers: BucketParameterQuerier[] = [];
128-
this.pushBucketParameterQueriers({ queriers, errors: [] }, options);
129-
130-
return mergeBucketParameterQueriers(queriers);
131121
}
132122
};
133123
}

0 commit comments

Comments
 (0)