Cleanup.

Author: rkistner

packages/sync-rules/src/SqlParameterQuery.ts

@@ -299,10 +299,6 @@ export class SqlParameterQuery
   readonly queryId: string;
   readonly tools: SqlTools;
 
-  readonly type: BucketSourceType = BucketSourceType.SYNC_RULE;
-
-  readonly subscribedToByDefault: boolean = true;
-
   readonly errors: SqlRuleError[];
 
   constructor(options: SqlParameterQueryOptions) {
@@ -326,10 +322,6 @@ export class SqlParameterQuery
     return this.sourceTable.matches(table);
   }
 
-  get name(): string {
-    return this.descriptorName;
-  }
-
   getSourceTables(): Set<TablePattern> {
     return new Set([this.sourceTable]);
   }

packages/sync-rules/src/StaticSqlParameterQuery.ts

@@ -161,9 +161,6 @@ export class StaticSqlParameterQuery implements BucketParameterQuerierSourceDefi
    */
   readonly filter: ParameterValueClause | undefined;
 
-  readonly subscribedToByDefault = true;
-  readonly type = BucketSourceType.SYNC_RULE;
-
   readonly errors: SqlRuleError[];
 
   constructor(options: StaticSqlParameterQueryOptions) {
@@ -177,10 +174,6 @@ export class StaticSqlParameterQuery implements BucketParameterQuerierSourceDefi
     this.errors = options.errors ?? [];
   }
 
-  get name() {
-    return this.descriptorName;
-  }
-
   getSourceTables() {
     return new Set<TablePattern>();
   }
@@ -200,7 +193,7 @@ export class StaticSqlParameterQuery implements BucketParameterQuerierSourceDefi
         ).map((desc) => {
           return {
             ...desc,
-            definition: this.name,
+            definition: this.descriptorName,
             inclusion_reasons: ['default']
           } satisfies ResolvedBucket;
         });

packages/sync-rules/src/TableValuedFunctionSqlParameterQuery.ts

@@ -200,9 +200,6 @@ export class TableValuedFunctionSqlParameterQuery implements BucketParameterQuer
 
   readonly errors: SqlRuleError[];
 
-  readonly subscribedToByDefault = true;
-  readonly type = BucketSourceType.SYNC_RULE;
-
   constructor(options: TableValuedFunctionSqlParameterQueryOptions) {
     this.sql = options.sql;
     this.parameterExtractors = options.parameterExtractors;
@@ -219,10 +216,6 @@ export class TableValuedFunctionSqlParameterQuery implements BucketParameterQuer
     this.errors = options.errors;
   }
 
-  get name() {
-    return this.descriptorName;
-  }
-
   getSourceTables() {
     return new Set<TablePattern>();
   }
@@ -242,7 +235,7 @@ export class TableValuedFunctionSqlParameterQuery implements BucketParameterQuer
         ).map((desc) => {
           return {
             ...desc,
-            definition: this.name,
+            definition: this.descriptorName,
             inclusion_reasons: ['default']
           } satisfies ResolvedBucket;
         });